chore: improve link parser and its tests a bit #5522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QCompareCaseInsensitive
andstd::set
(no more allocations when searching for domains)That's the most coverage we can get out of it (codecov doesn't really show which cases were covered in case of partial coverage).
None of the following checks will trigger, because there will always be three dots and never duplicated dots (guaranteed from the caller,
parse
):chatterino2/src/common/LinkParser.cpp
Line 64 in a0b70b8
I could remove them, but that makes it a bit more fragile.
Similar things go for
chatterino2/src/common/LinkParser.cpp
Line 89 in a0b70b8
With the only difference that we're not guaranteed that
host
doesn't end in.
(there's a test for it).