Remove experimental IRC support #5547

pajlada · 2024-08-17T11:04:02Z

#5498

It no longer relies on AbstractIrcServer & IAbstractIrcServer

github-actions

clang-tidy made some suggestions

mocks/include/mocks/EmptyApplication.hpp

mocks/include/mocks/TwitchIrcServer.hpp

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+        QCoreApplication::instance()->thread());
+
+    // Apply a leaky bucket rate limiting to JOIN messages
+    auto actuallyJoin = [&](QString message) {


warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

Suggested change

auto actuallyJoin = [&](QString message) {

auto actuallyJoin = [&](const QString& message) {

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+    auto reconnected = makeSystemMessage("reconnected");
+    reconnected->flags.set(MessageFlag::ConnectedMessage);
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+    b->flags.set(MessageFlag::DisconnectedMessage);
+    auto disconnectedMsg = b.release();
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+    if (fakeMessage->command() == "PRIVMSG")
+    {
+        this->privateMessageReceived(
+            static_cast<Communi::IrcPrivateMessage *>(fakeMessage));


warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]

Suggested change

static_cast<Communi::IrcPrivateMessage *>(fakeMessage));

dynamic_cast<Communi::IrcPrivateMessage *>(fakeMessage));

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+    MessageBuilder b(systemMessage, messageText);
+    auto message = b.release();
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-17T11:21:22Z

src/providers/twitch/TwitchIrcServer.cpp

+{
+    std::lock_guard<std::mutex> lock(this->channelMutex);
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

src/providers/twitch/TwitchIrcServer.hpp

github-actions

clang-tidy made some suggestions

mocks/include/mocks/EmptyApplication.hpp

mocks/include/mocks/TwitchIrcServer.hpp

src/providers/twitch/TwitchIrcServer.cpp

src/providers/twitch/TwitchIrcServer.hpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-08-18T11:56:26Z

mocks/include/mocks/EmptyApplication.hpp

@@ -133,7 +133,7 @@ class EmptyApplication : public IApplication
        return nullptr;
    }

-    IAbstractIrcServer *getTwitchAbstract() override
+    ITwitchIrcServer *getTwitchAbstract() override


warning: method 'getTwitchAbstract' can be made static [readability-convert-member-functions-to-static]

Suggested change

ITwitchIrcServer *getTwitchAbstract() override

static ITwitchIrcServer *getTwitchAbstract() override

github-actions · 2024-08-18T11:56:26Z

mocks/include/mocks/TwitchIrcServer.hpp

+    {
+    }
+
+    ChannelPtr getOrAddChannel(const QString &dirtyChannelName) override


warning: parameter 'dirtyChannelName' is unused [misc-unused-parameters]

Suggested change

ChannelPtr getOrAddChannel(const QString &dirtyChannelName) override

ChannelPtr getOrAddChannel(const QString & /*dirtyChannelName*/) override

github-actions · 2024-08-18T11:56:26Z

mocks/include/mocks/TwitchIrcServer.hpp

+        return {};
+    }
+
+    ChannelPtr getChannelOrEmpty(const QString &dirtyChannelName) override


warning: parameter 'dirtyChannelName' is unused [misc-unused-parameters]

Suggested change

ChannelPtr getChannelOrEmpty(const QString &dirtyChannelName) override

ChannelPtr getChannelOrEmpty(const QString & /*dirtyChannelName*/) override

github-actions · 2024-08-18T11:56:26Z

src/providers/twitch/TwitchIrcServer.cpp

+        QCoreApplication::instance()->thread());
+
+    // Apply a leaky bucket rate limiting to JOIN messages
+    auto actuallyJoin = [&](QString message) {


warning: the parameter 'message' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]

Suggested change

auto actuallyJoin = [&](QString message) {

auto actuallyJoin = [&](const QString& message) {

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.cpp

+    auto reconnected = makeSystemMessage("reconnected");
+    reconnected->flags.set(MessageFlag::ConnectedMessage);
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.cpp

+    b->flags.set(MessageFlag::DisconnectedMessage);
+    auto disconnectedMsg = b.release();
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.cpp

+    if (fakeMessage->command() == "PRIVMSG")
+    {
+        this->privateMessageReceived(
+            static_cast<Communi::IrcPrivateMessage *>(fakeMessage));


warning: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast]

Suggested change

static_cast<Communi::IrcPrivateMessage *>(fakeMessage));

dynamic_cast<Communi::IrcPrivateMessage *>(fakeMessage));

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.cpp

+    MessageBuilder b(systemMessage, messageText);
+    auto message = b.release();
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.cpp

+{
+    std::lock_guard<std::mutex> lock(this->channelMutex);
+
+    for (std::weak_ptr<Channel> &weak : this->channels.values())


warning: variable 'weak' of type 'std::weak_ptr &' can be declared 'const' [misc-const-correctness]

Suggested change

for (std::weak_ptr<Channel> &weak : this->channels.values())

for (std::weak_ptr<Channel> const&weak : this->channels.values())

github-actions · 2024-08-18T11:56:27Z

src/providers/twitch/TwitchIrcServer.hpp

 {
 public:
+    enum class ConnectionType {


warning: enum 'ConnectionType' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

enum class ConnectionType { ^

Mm2PL · 2024-08-18T22:15:51Z

Maybe I wasn't clear enough that I didn't want this to happen until we could migrate IRC to plugins. Maybe building all this back from the ground won't be that terrible Clueless

pajlada added 3 commits August 17, 2024 12:56

Make TwitchIrcServer an entire IrcServer(?) by itself

fd4967a

It no longer relies on AbstractIrcServer & IAbstractIrcServer

Remove experimental IRC support

ee93234

Add changelog entry

498ff41

github-actions bot reviewed Aug 17, 2024

View reviewed changes

pajlada added 3 commits August 17, 2024 13:21

destruct SeventvEventAPI in source file?

99fb4ed

don't forward-declare seventv eventapi subscription

e1770aa

add missing return for mock twitchircserver

f6a4a03

github-actions bot reviewed Aug 17, 2024

View reviewed changes

Merge branch 'master' into refactor/begin-demolishing-irc-support

9fa0521

pajlada enabled auto-merge (squash) August 18, 2024 11:38

github-actions bot reviewed Aug 18, 2024

View reviewed changes

pajlada merged commit 998920d into master Aug 18, 2024
17 checks passed

pajlada deleted the refactor/begin-demolishing-irc-support branch August 18, 2024 12:04

Nerixyz mentioned this pull request Aug 20, 2024

ci: show recent changes in nightly release #5553

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove experimental IRC support #5547

Remove experimental IRC support #5547

pajlada commented Aug 17, 2024

github-actions bot left a comment

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot Aug 17, 2024

github-actions bot left a comment

github-actions bot left a comment

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

Mm2PL commented Aug 18, 2024

	auto actuallyJoin = [&](QString message) {
	auto actuallyJoin = [&](const QString& message) {

	for (std::weak_ptr<Channel> &weak : this->channels.values())
	for (std::weak_ptr<Channel> const&weak : this->channels.values())

	static_cast<Communi::IrcPrivateMessage *>(fakeMessage));
	dynamic_cast<Communi::IrcPrivateMessage *>(fakeMessage));

	ITwitchIrcServer *getTwitchAbstract() override
	static ITwitchIrcServer *getTwitchAbstract() override

	ChannelPtr getOrAddChannel(const QString &dirtyChannelName) override
	ChannelPtr getOrAddChannel(const QString & /dirtyChannelName/) override

	ChannelPtr getChannelOrEmpty(const QString &dirtyChannelName) override
	ChannelPtr getChannelOrEmpty(const QString & /dirtyChannelName/) override

Remove experimental IRC support #5547

Remove experimental IRC support #5547

Conversation

pajlada commented Aug 17, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot Aug 17, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

Mm2PL commented Aug 18, 2024