refactor: make a single MessageBuilder #5548

pajlada · 2024-08-17T13:03:19Z

This removes TwitchMessageBuilder and SharedMessageBuilder, and moves all relevant functionality into MessageBuilder

MessageBuilder is chunky, but it's at least in one file now instead of spread out with little reason.

There's a few more things that could probably be done here, like making sure we make better use of static functions for message makers so consumers don't have to set message flags themselves.

A common pattern I still see is:

MessageBuilder builder(foo, bar);
builder.flags = asd;
auto msg = builder.release();

where we could just have a static function instead

auto msg = MessageBuilder::buildFooBar(foo, bar);

with an alternative parameter adding extra flags for ones that are a bit more dynamic

auto msg = MessageBuilder::buildFooBar(foo, bar, {ExtraFlag});

The function is now called `makeLiveMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

The function is now called `makeLiveSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

The function is now called `makeOfflineSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

The function is now called `makeHostingSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

The function is now called `makeListOfUsersSystemMEssage` and it creates the MessageBuilder itself, and returns a complete MessagePtr The Collapsed usage from `Chatters` is now part of the params

The function is now called `makeDeletionMessageFromIRC` and it creates the MessageBuilder itself, and returns a complete MessagePtr

The function is now called `makeDeletionMessageFromPubSub` and it creates the MessageBuilder itself, and returns a complete MessagePtr

It's been made into a non-static function, with an accompanying static function to make an empty MessageBuilder & use the non-static function on it.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 32. Check the log or trigger a new build to see more.

github-actions · 2024-08-18T12:26:07Z

src/messages/MessageBuilder.cpp

+
+const QColor AUTOMOD_USER_COLOR{"blue"};
+
+const QString regexHelpString("(\\w+)[.,!?;:]*?$");


warning: invalid case style for global constant 'regexHelpString' [readability-identifier-naming]

Suggested change

const QString regexHelpString("(\\w+)[.,!?;:]*?$");

const QString REGEX_HELP_STRING("(\\w+)[.,!?;:]*?$");

src/messages/MessageBuilder.cpp:66:

- const QRegularExpression mentionRegex("^@" + regexHelpString); + const QRegularExpression mentionRegex("^@" + REGEX_HELP_STRING);

src/messages/MessageBuilder.cpp:69:

- const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString); + const QRegularExpression allUsernamesMentionRegex("^" + REGEX_HELP_STRING);

github-actions · 2024-08-18T12:26:07Z

src/messages/MessageBuilder.cpp

+const QString regexHelpString("(\\w+)[.,!?;:]*?$");
+
+// matches a mention with punctuation at the end, like "@username," or "@username!!!" where capture group would return "username"
+const QRegularExpression mentionRegex("^@" + regexHelpString);


warning: invalid case style for global constant 'mentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression mentionRegex("^@" + regexHelpString);

const QRegularExpression MENTION_REGEX("^@" + regexHelpString);

src/messages/MessageBuilder.cpp:2441:

- { + {MENTION_REGEX

github-actions · 2024-08-18T12:26:07Z

src/messages/MessageBuilder.cpp

+const QRegularExpression mentionRegex("^@" + regexHelpString);
+
+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);


warning: invalid case style for global constant 'allUsernamesMentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);

const QRegularExpression ALL_USERNAMES_MENTION_REGEX("^" + regexHelpString);

src/messages/MessageBuilder.cpp:2476:

- { + {ALL_USERNAMES_MENTION_REGEX

github-actions · 2024-08-18T12:26:08Z

src/messages/MessageBuilder.cpp

+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);
+
+const QSet<QString> zeroWidthEmotes{


warning: invalid case style for global constant 'zeroWidthEmotes' [readability-identifier-naming]

Suggested change

const QSet<QString> zeroWidthEmotes{

const QSet<QString> ZERO_WIDTH_EMOTES{

src/messages/MessageBuilder.cpp:2902:

- mote; + mote;ZERO_WIDTH_EMOTES

github-actions · 2024-08-18T12:26:08Z

src/messages/MessageBuilder.cpp

+        return QUrl::fromLocalFile(path);
+    }
+
+    return QUrl("qrc:/sounds/ping2.wav");


warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]

return QUrl("qrc:/sounds/ping2.wav"); ^

github-actions · 2024-08-18T12:26:09Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

el && ^

Additional context

src/messages/MessageBuilder.cpp:2885: if it should be an assignment, move it out of the 'if' condition

el && ^

src/messages/MessageBuilder.cpp:2885: if it is meant to be an equality check, change '=' to '=='

el && ^

github-actions · 2024-08-18T12:26:09Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: implicit conversion 'TwitchChannel *' -> 'bool' [readability-implicit-bool-conversion]

Suggested change

(emote = this->twitchChannel->bttvEmote(name)))

}

el &&( != nullptr)

github-actions · 2024-08-18T12:26:09Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::BttvEmote;
+    }
+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

tr && ^

Additional context

src/messages/MessageBuilder.cpp:2890: if it should be an assignment, move it out of the 'if' condition

tr && ^

src/messages/MessageBuilder.cpp:2890: if it is meant to be an equality check, change '=' to '=='

tr && ^

github-actions · 2024-08-18T12:26:09Z

src/messages/MessageBuilder.cpp

+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))
+    {
+        flags = MessageElementFlag::SevenTVEmote;


warning: repeated branch body in conditional chain [bugprone-branch-clone]

{ ^

Additional context

src/messages/MessageBuilder.cpp:2895: end of the original

} ^

src/messages/MessageBuilder.cpp:2906: clone 1 starts here

{ ^

github-actions · 2024-08-18T12:26:09Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::SevenTVEmote;
+        zeroWidth = emote.value()->zeroWidth;
+    }
+    else if ((emote = globalFfzEmotes->emote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

} ^

Additional context

src/messages/MessageBuilder.cpp:2895: if it should be an assignment, move it out of the 'if' condition

} ^

src/messages/MessageBuilder.cpp:2895: if it is meant to be an equality check, change '=' to '=='

} ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 33. Check the log or trigger a new build to see more.

github-actions · 2024-08-18T17:15:13Z

benchmarks/src/Highlights.cpp

@@ -16,15 +16,16 @@

 using namespace chatterino;

-class BenchmarkMessageBuilder : public SharedMessageBuilder
+class BenchmarkMessageBuilder : public MessageBuilder


warning: destructor of 'BenchmarkMessageBuilder' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]

class BenchmarkMessageBuilder : public MessageBuilder ^

Additional context

benchmarks/src/Highlights.cpp:18: make it public and virtual

class BenchmarkMessageBuilder : public MessageBuilder ^

github-actions · 2024-08-18T17:15:13Z

src/messages/MessageBuilder.cpp

+
+const QColor AUTOMOD_USER_COLOR{"blue"};
+
+const QString regexHelpString("(\\w+)[.,!?;:]*?$");


warning: invalid case style for global constant 'regexHelpString' [readability-identifier-naming]

Suggested change

const QString regexHelpString("(\\w+)[.,!?;:]*?$");

const QString REGEX_HELP_STRING("(\\w+)[.,!?;:]*?$");

src/messages/MessageBuilder.cpp:66:

- const QRegularExpression mentionRegex("^@" + regexHelpString); + const QRegularExpression mentionRegex("^@" + REGEX_HELP_STRING);

src/messages/MessageBuilder.cpp:69:

- const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString); + const QRegularExpression allUsernamesMentionRegex("^" + REGEX_HELP_STRING);

github-actions · 2024-08-18T17:15:13Z

src/messages/MessageBuilder.cpp

+const QString regexHelpString("(\\w+)[.,!?;:]*?$");
+
+// matches a mention with punctuation at the end, like "@username," or "@username!!!" where capture group would return "username"
+const QRegularExpression mentionRegex("^@" + regexHelpString);


warning: invalid case style for global constant 'mentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression mentionRegex("^@" + regexHelpString);

const QRegularExpression MENTION_REGEX("^@" + regexHelpString);

src/messages/MessageBuilder.cpp:2441:

- { + {MENTION_REGEX

github-actions · 2024-08-18T17:15:13Z

src/messages/MessageBuilder.cpp

+const QRegularExpression mentionRegex("^@" + regexHelpString);
+
+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);


warning: invalid case style for global constant 'allUsernamesMentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);

const QRegularExpression ALL_USERNAMES_MENTION_REGEX("^" + regexHelpString);

src/messages/MessageBuilder.cpp:2476:

- { + {ALL_USERNAMES_MENTION_REGEX

github-actions · 2024-08-18T17:15:13Z

src/messages/MessageBuilder.cpp

+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);
+
+const QSet<QString> zeroWidthEmotes{


warning: invalid case style for global constant 'zeroWidthEmotes' [readability-identifier-naming]

Suggested change

const QSet<QString> zeroWidthEmotes{

const QSet<QString> ZERO_WIDTH_EMOTES{

src/messages/MessageBuilder.cpp:2902:

- mote; + mote;ZERO_WIDTH_EMOTES

github-actions · 2024-08-18T17:15:14Z

src/messages/MessageBuilder.cpp

+    //  - 7TV Global
+    if (this->twitchChannel && (emote = this->twitchChannel->ffzEmote(name)))
+    {
+        flags = MessageElementFlag::FfzEmote;


warning: repeated branch body in conditional chain [bugprone-branch-clone]

{ ^

Additional context

src/messages/MessageBuilder.cpp:2884: end of the original

} ^

src/messages/MessageBuilder.cpp:2897: clone 1 starts here

{ ^

github-actions · 2024-08-18T17:15:14Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

el && ^

Additional context

src/messages/MessageBuilder.cpp:2885: if it should be an assignment, move it out of the 'if' condition

el && ^

src/messages/MessageBuilder.cpp:2885: if it is meant to be an equality check, change '=' to '=='

el && ^

github-actions · 2024-08-18T17:15:15Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: implicit conversion 'TwitchChannel *' -> 'bool' [readability-implicit-bool-conversion]

Suggested change

(emote = this->twitchChannel->bttvEmote(name)))

}

el &&( != nullptr)

github-actions · 2024-08-18T17:15:15Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::BttvEmote;
+    }
+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

tr && ^

Additional context

src/messages/MessageBuilder.cpp:2890: if it should be an assignment, move it out of the 'if' condition

tr && ^

src/messages/MessageBuilder.cpp:2890: if it is meant to be an equality check, change '=' to '=='

tr && ^

github-actions · 2024-08-18T17:15:15Z

src/messages/MessageBuilder.cpp

+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))
+    {
+        flags = MessageElementFlag::SevenTVEmote;


warning: repeated branch body in conditional chain [bugprone-branch-clone]

{ ^

Additional context

src/messages/MessageBuilder.cpp:2895: end of the original

} ^

src/messages/MessageBuilder.cpp:2906: clone 1 starts here

{ ^

…ilder

pajlada · 2024-08-24T09:44:41Z

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 33. Check the log or trigger a new build to see more.

github-actions · 2024-08-24T10:06:40Z

benchmarks/src/Highlights.cpp

@@ -16,15 +16,16 @@

 using namespace chatterino;

-class BenchmarkMessageBuilder : public SharedMessageBuilder
+class BenchmarkMessageBuilder : public MessageBuilder


warning: destructor of 'BenchmarkMessageBuilder' is public and non-virtual [cppcoreguidelines-virtual-class-destructor]

class BenchmarkMessageBuilder : public MessageBuilder ^

Additional context

benchmarks/src/Highlights.cpp:18: make it public and virtual

class BenchmarkMessageBuilder : public MessageBuilder ^

github-actions · 2024-08-24T10:06:40Z

src/messages/MessageBuilder.cpp

+
+const QColor AUTOMOD_USER_COLOR{"blue"};
+
+const QString regexHelpString("(\\w+)[.,!?;:]*?$");


warning: invalid case style for global constant 'regexHelpString' [readability-identifier-naming]

Suggested change

const QString regexHelpString("(\\w+)[.,!?;:]*?$");

const QString REGEX_HELP_STRING("(\\w+)[.,!?;:]*?$");

src/messages/MessageBuilder.cpp:66:

- const QRegularExpression mentionRegex("^@" + regexHelpString); + const QRegularExpression mentionRegex("^@" + REGEX_HELP_STRING);

src/messages/MessageBuilder.cpp:69:

- const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString); + const QRegularExpression allUsernamesMentionRegex("^" + REGEX_HELP_STRING);

github-actions · 2024-08-24T10:06:40Z

src/messages/MessageBuilder.cpp

+const QString regexHelpString("(\\w+)[.,!?;:]*?$");
+
+// matches a mention with punctuation at the end, like "@username," or "@username!!!" where capture group would return "username"
+const QRegularExpression mentionRegex("^@" + regexHelpString);


warning: invalid case style for global constant 'mentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression mentionRegex("^@" + regexHelpString);

const QRegularExpression MENTION_REGEX("^@" + regexHelpString);

src/messages/MessageBuilder.cpp:2441:

- { + {MENTION_REGEX

github-actions · 2024-08-24T10:06:40Z

src/messages/MessageBuilder.cpp

+const QRegularExpression mentionRegex("^@" + regexHelpString);
+
+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);


warning: invalid case style for global constant 'allUsernamesMentionRegex' [readability-identifier-naming]

Suggested change

const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);

const QRegularExpression ALL_USERNAMES_MENTION_REGEX("^" + regexHelpString);

src/messages/MessageBuilder.cpp:2476:

- { + {ALL_USERNAMES_MENTION_REGEX

github-actions · 2024-08-24T10:06:41Z

src/messages/MessageBuilder.cpp

+// if findAllUsernames setting is enabled, matches strings like in the examples above, but without @ symbol at the beginning
+const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);
+
+const QSet<QString> zeroWidthEmotes{


warning: invalid case style for global constant 'zeroWidthEmotes' [readability-identifier-naming]

Suggested change

const QSet<QString> zeroWidthEmotes{

const QSet<QString> ZERO_WIDTH_EMOTES{

src/messages/MessageBuilder.cpp:2902:

- mote; + mote;ZERO_WIDTH_EMOTES

github-actions · 2024-08-24T10:06:42Z

src/messages/MessageBuilder.cpp

+    //  - 7TV Global
+    if (this->twitchChannel && (emote = this->twitchChannel->ffzEmote(name)))
+    {
+        flags = MessageElementFlag::FfzEmote;


warning: repeated branch body in conditional chain [bugprone-branch-clone]

{ ^

Additional context

src/messages/MessageBuilder.cpp:2884: end of the original

} ^

src/messages/MessageBuilder.cpp:2897: clone 1 starts here

{ ^

github-actions · 2024-08-24T10:06:42Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

el && ^

Additional context

src/messages/MessageBuilder.cpp:2885: if it should be an assignment, move it out of the 'if' condition

el && ^

src/messages/MessageBuilder.cpp:2885: if it is meant to be an equality check, change '=' to '=='

el && ^

github-actions · 2024-08-24T10:06:42Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::FfzEmote;
+    }
+    else if (this->twitchChannel &&
+             (emote = this->twitchChannel->bttvEmote(name)))


warning: implicit conversion 'TwitchChannel *' -> 'bool' [readability-implicit-bool-conversion]

Suggested change

(emote = this->twitchChannel->bttvEmote(name)))

}

el &&( != nullptr)

github-actions · 2024-08-24T10:06:42Z

src/messages/MessageBuilder.cpp

+        flags = MessageElementFlag::BttvEmote;
+    }
+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))


warning: an assignment within an 'if' condition is bug-prone [bugprone-assignment-in-if-condition]

tr && ^

Additional context

src/messages/MessageBuilder.cpp:2890: if it should be an assignment, move it out of the 'if' condition

tr && ^

src/messages/MessageBuilder.cpp:2890: if it is meant to be an equality check, change '=' to '=='

tr && ^

github-actions · 2024-08-24T10:06:42Z

src/messages/MessageBuilder.cpp

+    else if (this->twitchChannel != nullptr &&
+             (emote = this->twitchChannel->seventvEmote(name)))
+    {
+        flags = MessageElementFlag::SevenTVEmote;


warning: repeated branch body in conditional chain [bugprone-branch-clone]

{ ^

Additional context

src/messages/MessageBuilder.cpp:2895: end of the original

} ^

src/messages/MessageBuilder.cpp:2906: clone 1 starts here

{ ^

pajlada force-pushed the refactor/message-builder branch from d99b081 to 471a55f Compare August 18, 2024 10:25

pajlada added 13 commits August 18, 2024 14:05

refactor: merge Twitch/SharedMessageBuilder into MessageBuilder

6c857d5

refactor MessageBuilder::liveMessage

baa5005

The function is now called `makeLiveMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::liveSystemMessage

8f4b481

The function is now called `makeLiveSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::offlineSystemMessage

dcd2b3e

The function is now called `makeOfflineSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::hostingSystemMessage

9b247e6

The function is now called `makeHostingSystemMessage` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::listOfUsersSystemMEssage

79ec26c

The function is now called `makeListOfUsersSystemMEssage` and it creates the MessageBuilder itself, and returns a complete MessagePtr The Collapsed usage from `Chatters` is now part of the params

refactor MessageBuilder::deletionMessage (irc variant)

b72229d

The function is now called `makeDeletionMessageFromIRC` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::deletionMessage (pubsub variant)

12e96a0

The function is now called `makeDeletionMessageFromPubSub` and it creates the MessageBuilder itself, and returns a complete MessagePtr

refactor MessageBuilder::appendChannelPointRewardMessage

7569d4a

It's been made into a non-static function, with an accompanying static function to make an empty MessageBuilder & use the non-static function on it.

actually MessageBuilder can be public

397997f

Combine makeLiveMessage and makeLiveSystemMessage into one function

706d051

remove clang-format off section from messagebuilder

cba4588

Further refactor makeListOfUsersMessage

4fc7389

pajlada force-pushed the refactor/message-builder branch from c601dd6 to 4fc7389 Compare August 18, 2024 12:05

pajlada marked this pull request as ready for review August 18, 2024 12:05

github-actions bot reviewed Aug 18, 2024

View reviewed changes

fix benchmarks

49ab140

github-actions bot reviewed Aug 18, 2024

View reviewed changes

pajlada added 2 commits August 24, 2024 11:43

Merge remote-tracking branch 'origin/master' into refactor/message-bu…

71dbc4e

…ilder

add changelog entry

5055361

pajlada enabled auto-merge (squash) August 24, 2024 09:44

github-actions bot reviewed Aug 24, 2024

View reviewed changes

pajlada merged commit 175afa8 into master Aug 24, 2024
17 checks passed

pajlada deleted the refactor/message-builder branch August 24, 2024 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: make a single MessageBuilder #5548

refactor: make a single MessageBuilder #5548

pajlada commented Aug 17, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot left a comment

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

github-actions bot Aug 18, 2024

pajlada commented Aug 24, 2024

github-actions bot left a comment

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024

github-actions bot Aug 24, 2024


		const QColor AUTOMOD_USER_COLOR{"blue"};

		const QString regexHelpString("(\\w+)[.,!?;:]*?$");

	const QString regexHelpString("(\\w+)[.,!?;:]*?$");
	const QString REGEX_HELP_STRING("(\\w+)[.,!?;:]*?$");

	const QRegularExpression mentionRegex("^@" + regexHelpString);
	const QRegularExpression MENTION_REGEX("^@" + regexHelpString);

	const QRegularExpression allUsernamesMentionRegex("^" + regexHelpString);
	const QRegularExpression ALL_USERNAMES_MENTION_REGEX("^" + regexHelpString);

	const QSet<QString> zeroWidthEmotes{
	const QSet<QString> ZERO_WIDTH_EMOTES{

	(emote = this->twitchChannel->bttvEmote(name)))
	}
	el &&( != nullptr)

refactor: make a single MessageBuilder #5548

refactor: make a single MessageBuilder #5548

Conversation

pajlada commented Aug 17, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

github-actions bot Aug 18, 2024

Choose a reason for hiding this comment

pajlada commented Aug 24, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

github-actions bot Aug 24, 2024

Choose a reason for hiding this comment

pajlada commented Aug 17, 2024 •

edited

Loading