Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move zero width replacement to a function #5594

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Sep 14, 2024

Refactors and tests the Unicode zero-width-joiner replacement. The replacement is now in a helper function (so we can test it) and the individual components use Unicode string literals. (From #5588).

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if this was split into two PRs (or at the very least commits with tests being allowed to fully run)

  1. Moving the logic to a function, and adding tests for it
  2. Change way we encode the characters

@pajlada pajlada requested a review from Mm2PL September 17, 2024 12:42
@Mm2PL Mm2PL enabled auto-merge (squash) September 28, 2024 12:21
@Mm2PL Mm2PL merged commit d0bcf35 into Chatterino:master Sep 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants