-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(message-builder): move static helper methods to functions #5652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameters equal to originalMessage were renamed to content to avoid confusion with the original message text, which might be bigger.
I don't understand the reasoning behind the change - I don't really care too much about it, but I don't see how originalMessage
would be incorrect
It's not incorrect, but it's misleading. For the reply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Sure, I guess that depends on how you interpret "message" and "content". Libcommuni interprets "content" as |
These functions shouldn't live in the message builder. They're related to IRC and Ignores.
IRC related functions are in
TwitchIrc
and in thechatterino::twitchirc
namespace. All functions were copied. Only parameters equal tooriginalMessage
were renamed tocontent
to avoid confusion with the original message text, which might be bigger.In the future, we should get rid of the
int
s in this code.clang-tidy will complain, but I didn't change anything.