refactor: move MessageBuilder snapshot test to IrcMessageHandler #5654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
refactor/mb-to-irc
branch
from
a436adf to
c6414f2
Compare
pajlada
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
tests/src/MessageBuilder.cpptotests/src/IrcMessageHandler.cppand moves the snapshots accordingly. The message builder tests only consisted of the snapshot tests. These tests are more forIrcMessageHandler(or rather: that's their entry). Still, one major goal for them is to test the message builder. But in the future, they should also test other IRC messages (subs etc.).