feat: add shared chat badge

[iProdigy]

[github-actions]

clang-tidy made some suggestions

[iProdigy]

technically we could reduce the number of helix requests made by using https://dev.twitch.tv/docs/api/reference/#get-shared-chat-session

e.g., if shared chat has 6 channels, the current approach could make up to 5 helix requests while the alternate approach would just do 1 - but not a big deal in the context of the full app lifetime

[pajlada]

small nits, not tested yet - overall looks good. badge looks good

TODO for myself: test right-click actions on shared channel badges

[pajlada]

Copying works as expected

I'm not fond of the badge being a mention element - I think I would prefer it to have no left-click action and instead a right-click action for some actions for the user (which I'm fine to leave out of this PR)

[8thony]

I got a crash with all settings set to default and then joined a channel with Shared Chat enabled.
Tested on a9b446f

Another option could be that instead of a badge, we put the channel profile picture in front of the message.

[pajlada]

Another option could be that instead of a badge, we put the channel profile picture in front of the message.

I'd rather that be part of a follow-up PR as a "polish pass", which would let us discuss it first too

[iProdigy]

@8thony could you share the channel name (& the other channels that were in the shared chat session & whether you were also connected to any of those channels)

also the stacktrace from the crash dump would be very helpful

[8thony]

The Shared Chat Session had 2 People and I opened only one channel from those.
c2 had no settings, no account, no cache files, nothing setup.
You can rename your %appdata%\chatterino2 folder to something else to test this.

Stack

Stack:

Qt6Core.dll!00007ffb7ac88ae0() Unknown
chatterino.exe!qHash(const QString & key, unsigned __int64 seed) Line 153 C++
[Inline Frame] chatterino.exe!std::hash::operator()(const QString &) Line 324 C++
[Inline Frame] chatterino.exe!std::_Uhash_compare<QString,std::hash,std::equal_to>::operator()(const QString &) Line 145 C++
[Inline Frame] chatterino.exe!std::_Hash<std::_Umap_traits<QString,std::_List_iterator<std::_List_val<std::_List_simple_types<std::pair<QString,QString>>>>,std::_Uhash_compare<QString,std::hash,std::equal_to>,std::allocator<std::pair<QString const ,std::_List_iterator<std::_List_val<std::_List_simple_types<std::pair<QString,QString>>>>>>,0>>::find(const QString &) Line 1230 C++
[Inline Frame] chatterino.exe!cache::lru_cache<QString,QString>::exists(const QString &) Line 102 C++
[Inline Frame] chatterino.exe!chatterino::TwitchIrcServer::getOrPopulateChannelCache::__l2::<lambda_2>::operator()() Line 1154 C++
[Inline Frame] chatterino.exe!std::invoke(chatterino::TwitchIrcServer::getOrPopulateChannelCache::__l2::<lambda_2> &) Line 1704 C++
chatterino.exe!std::_Func_impl_no_alloc<chatterino::TwitchIrcServer::getOrPopulateChannelCache'::2'::<lambda_2>,void>::_Do_call() Line 874 C++
[Inline Frame] chatterino.exe!std::_Func_class::operator()() Line 920 C++
[Inline Frame] chatterino.exe!chatterino::Helix::blockUser::__l2::<lambda_2>::operator()(chatterino::NetworkResult) Line 594 C++
[Inline Frame] chatterino.exe!std::invoke(chatterino::Helix::blockUser::__l2::<lambda_2> &) Line 1714 C++
chatterino.exe!std::_Func_impl_no_alloc<chatterino::Helix::blockUser'::2'::<lambda_2>,void,chatterino::NetworkResult>::_Do_call(chatterino::NetworkResult && <_Args_0>) Line 874 C++
> [Inline Frame] chatterino.exe!std::_Func_class<void,chatterino::NetworkResult>::operator()(chatterino::NetworkResult) Line 920 C++
chatterino.exe!chatterino::NetworkData::emitError::__l2::<lambda_1>::operator()() Line 162 C++
[Inline Frame] chatterino.exe!chatterino::postToThread::__l2::Event::{dtor}() Line 30 C++
chatterino.exe!chatterino::postToThread<chatterino::NetworkData::emitError'::2'::<lambda_1> &>'::2'::Event::`scalar deleting destructor'(unsigned int) C++
Qt6Core.dll!00007ffb7ad10dc2() Unknown
Qt6Gui.dll!00007ffb7b61e2df() Unknown
Qt6Core.dll!00007ffb7ae9d360() Unknown
Qt6Gui.dll!00007ffb7b61e259() Unknown
Qt6Core.dll!00007ffb7ad1552f() Unknown
Qt6Core.dll!00007ffb7ad0b17d() Unknown
chatterino.exe!chatterino::runGui(QApplication & a, const chatterino::Paths & paths, chatterino::Settings & settings, const chatterino::Args & args, chatterino::Updates & updates) Line 267 C++
chatterino.exe!main(int argc, char * * argv) Line 122 C++
chatterino.exe!qtEntryPoint() Line 50 C++
[Inline Frame] chatterino.exe!invoke_main() Line 102 C++
chatterino.exe!__scrt_common_main_seh() Line 288 C++
kernel32.dll!00007ffbadf87374() Unknown
ntdll.dll!00007ffbaf83cc91() Unknown


[iProdigy]

@8thony could you confirm the crash is now fixed?

[8thony]

Yes, no crash anymore.