fix: subscribed threads not being marked as subscribed

[pajlada]

Got another branch going which updates unit tests to properly catch this

cc @Nerixyz if you want to take a peek - I imagine this was roughly the intent you had

[Nerixyz]

cc @Nerixyz if you want to take a peek - I imagine this was roughly the intent you had

Not exactly. If the thread isn't highlighted, that's an issue with the IrcMessageHandler, which sets the flag (https://github.com/Chatterino/chatterino2/blob/master/src/providers/twitch/IrcMessageHandler.cpp#L729).

[pajlada]

cc @Nerixyz if you want to take a peek - I imagine this was roughly the intent you had

Not exactly. If the thread isn't highlighted, that's an issue with the IrcMessageHandler, which sets the flag (master/src/providers/twitch/IrcMessageHandler.cpp#L729).

Setting SubscribedThread here is too late for the highlight controller to act on, will keep current implementation for now

[Nerixyz]

Setting SubscribedThread here is too late for the highlight controller to act on, will keep current implementation for now

Then we can drop the highlight in the reply context.