Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make usernames in USERNOTICEs clickable #5686

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 2, 2024

Does what the title says. For subgifts, there's a special case, since their messages include two usernames.

Fixes #2673

@jupjohn
Copy link
Contributor

jupjohn commented Nov 3, 2024

All of the examples I found are user notices, so makes sense 👍

@pajlada pajlada enabled auto-merge (squash) November 3, 2024 10:49
@pajlada pajlada merged commit 8220a1f into Chatterino:master Nov 3, 2024
18 checks passed
@jupjohn
Copy link
Contributor

jupjohn commented Nov 10, 2024

This is a great enhancement, thanks for implementing this Neri 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Usernames Clickable Everywhere (or at least add an option to have them clickable everywhere)
3 participants