-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: use upstream qtkeychain #5697
Conversation
not super correct but good enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swap to our forks' master branch instead, and next release we can swap repo url
...why? Both branches are at the same commit. If we use the upstream version, we get updates through dependabot (assuming it's not disabled). |
Changing remote throws off build systems that don't use git submodules directly, instead relying on user-input submodules. If possible I like to make those changes together with, or after, a release |
How would that be different when using the fork versus the upstream version? If the author has to update submodules manually, they'd need to specify the new commit either way. This really shows how bad submodules are for dependencies. |
Nothing requires us to use the forked version, so let's use the upstream version. That one has too many warnings on
clang-cl
but that's not a compiler we officially support.