Deduplicate emotes by name in smart tab emote completion strategy #5705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-zlobintsev
force-pushed
the
tab-emote-deduplication
branch
from
808cc79 to
11a85fd
Compare
pajlada
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so if there are multiple emotes with the same name (for example from different sources) and you are using the "smarter emote completion" option, when tabbing through them it no longer cycles through all the instances of the same name.
Originally I changed this in
SmartEmoteStrategy, but this ended up removing duplicates from the : dropdown menu as well, which is not something we want I believe. Now it's deduplicated specifically inTabCompletionModelregardless of the emote strategy, but I think this should be fine as it's a cheap operation.