fix: scroll to bottom when setting a channel #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5737 I changed
performLayouttoqueueLayoutinChannelView::setChannel. This causes usercards and reply thread popups to have their scrollbar at the top when opened (specifically, this would resolve totruebefore, because the scrollbar was still hidden).This PR fixes that. For the various channel views, we need to make sure that they're properly initialized. For emojis, we need to make sure the view starts at the top, so we set the channel first and then add messages. On the other hand, for reply thread popups, we want to scroll to the bottom, hence we set the (virtual) channel after adding all messages.
I don't want to revert #5737 just because we relied on that initial layout.