Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emote-popup): ignore null gemometry #5751

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(emote-popup): ignore null gemometry #5751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17d4e06
fix(emote-popup): ignore null gemometry
Nerixyz Dec 2, 2024
9f04fae
chore: add to changelog
Nerixyz Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
- Minor: Colored usernames now update on the fly when changing the "Color @usernames" setting. (#5300)
- Minor: Added `flags.action` filter variable, allowing you to filter on `/me` messages. (#5397)
- Minor: Added the ability for `/ban`, `/timeout`, `/unban`, and `/untimeout` to specify multiple channels to duplicate the action to. Example: `/timeout --channel id:11148817 --channel testaccount_420 forsen 7m game complaining`. (#5402)
- Minor: The size of the emote popup is now saved. (#5415)
- Minor: The size of the emote popup is now saved. (#5415, #5751)
- Minor: Added the ability to duplicate tabs. (#5277)
- Minor: Improved error messages for channel update commands. (#5429)
- Minor: Moderators can now see when users are warned. (#5441)
Expand Down
6 changes: 5 additions & 1 deletion src/widgets/dialogs/EmotePopup.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,11 @@ void EmotePopup::filterEmotes(const QString &searchText)

void EmotePopup::saveBounds() const
{
getApp()->getWindows()->setEmotePopupBounds(this->getBounds());
auto bounds = this->getBounds();
if (!bounds.isNull())
{
getApp()->getWindows()->setEmotePopupBounds(bounds);
}
}

void EmotePopup::resizeEvent(QResizeEvent *event)
Expand Down
Loading