Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unescape Twitch emotes even more #5786

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jan 3, 2025

The code I changed (introduced in #861) never ran before #5239 (tested 03b0e48). So yea, this does another layer of unescaping, essentially.

Fixes #5785.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/providers/twitch/TwitchEmotes.cpp Show resolved Hide resolved
@pajlada pajlada merged commit 2212ec0 into Chatterino:master Jan 3, 2025
18 checks passed
@Nerixyz Nerixyz deleted the fix/html-emote-escape branch January 3, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitch emote names have HTML character escape sequences inserted
2 participants