add read total fil transferred from stats #13
Merged
+58
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
Jun 20, 2024
| export const getTransfersFromStats = async (): Promise<bigint> => { | ||
| const res = await fetch( | ||
| 'https://stats.filspark.com/transfers/daily' + | ||
| `?from=2024-01-01&to=${new Date().toISOString().split('T')[0]}` |
There was a problem hiding this comment.
We have historic transfers up to 06/11/2024, but here you are querying stats from 01/01/2024. There is an overlap of ~5.5 months. Will we count some transfers twice?
I'd prefer to set from=2024-06-12 to make it clear that we want only transfers made after the last manually-recorded historic value.
What do you think? Am I missing something?
There was a problem hiding this comment.
good idea! #2465a21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally we don't need to keep this updated any more 🥳