Add evaluate service #1
Conversation
| ieContract.on('MeasurementsAdded', (cid, _roundIndex) => { | ||
| const roundIndex = Number(_roundIndex) | ||
| if (cidsSeen.includes(cid)) return | ||
| cidsSeen.push(cid) |
There was a problem hiding this comment.
IIUC, this array will keep growing until we run out of memory.
Have you considered remembering only the last N items, where N is for example 1000?
Also, what happens when we restart the service, e.g. after deploying a new version? The list of CIDs seen will be lost. How is that going to impact the evaluation?
There was a problem hiding this comment.
Added a fix 👍
The service restarting isn't a problem, we're mostly debouncing here anyway
- if we preprocess redundantly, there will be extra work but the results won't change
- if we evaluate redundantly, there will be extra work and gas, but the results won't change
| const res = await web3Storage.get(cid) | ||
| const files = await res.files() | ||
| const measurements = JSON.parse(await files[0].text()) | ||
| return measurements |
There was a problem hiding this comment.
Observability (after this PR is landed): I would consider reporting the number of measurements as a new telemetry point and visualising it in Grafana. I think both the "number of measurements per CID" and "number of measurements per round" are potentially useful metrics to watch.
This has already been deployed to fly.io 🙏
Closes CheckerNetwork/roadmap#29
Closes CheckerNetwork/roadmap#33
@bajtos happy to fulfil change requests or hand over
TODO: