Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per-miner RSR #265

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Add per-miner RSR #265

merged 2 commits into from
Dec 3, 2024

Conversation

pyropy
Copy link
Contributor

@pyropy pyropy commented Dec 3, 2024

@pyropy pyropy requested review from juliangruber and bajtos December 3, 2024 11:24
@pyropy pyropy self-assigned this Dec 3, 2024
bajtos
bajtos requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was quick!

The changes look great at the high level; let's improve a few details now.

stats/lib/stats-fetchers.js Show resolved Hide resolved
stats/test/handler.test.js Outdated Show resolved Hide resolved
@pyropy pyropy requested a review from bajtos December 3, 2024 13:36
bajtos
bajtos approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

What's next:

  • Merge the main branch into your feature branch (e.g. using the button in the GitHub UI)
  • Wait for all CI checks to finish
  • Merge the pull request 🚀

@pyropy pyropy merged commit e41bf63 into main Dec 3, 2024
10 checks passed
@pyropy pyropy deleted the per-miner-rsr branch December 3, 2024 18:29
juliangruber
juliangruber reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangruber juliangruber juliangruber left review comments

@bajtos bajtos bajtos approved these changes

Assignees

@pyropy pyropy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyropy @juliangruber @bajtos