Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Zinnia.walletAddress API #123

Merged
merged 2 commits into from
Mar 22, 2023
Merged

feat: add Zinnia.walletAddress API #123

merged 2 commits into from
Mar 22, 2023

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 21, 2023

Allow modules to access the wallet address where to send rewards. The value is hard-coded to a testnet address for now.

When running inside the Station, this API will return the Station wallet address.

In the future, we can allow CLI users to configure this address too.

Connect to #75

Allow modules to access the wallet address where to send rewards.
The value is hard-coded to a testnet address for now.

When running inside the Station, this API will return the Station wallet
address.

In the future, we can allow CLI users to configure this address too.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos force-pushed the feat-wallet-address branch from b80771a to b57399c Compare March 21, 2023 12:01
@bajtos bajtos marked this pull request as ready for review March 21, 2023 12:02
@bajtos bajtos requested a review from juliangruber March 21, 2023 12:02
@bajtos bajtos mentioned this pull request Mar 21, 2023
11 tasks
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber March 21, 2023 17:24
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Again I might be totally wrong, but I assume String::from("hardcoded") is more idiomatic than "hardcoded".to_owned()

@bajtos bajtos merged commit 9599f95 into main Mar 22, 2023
@bajtos bajtos deleted the feat-wallet-address branch March 22, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants