ci: run tests on macOS #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have platform-specific code in `zinniad` that should be tested on macOS too. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
| # - target: aarch64-apple-darwin | ||
| # os: macos-latest | ||
| - target: "x86_64-apple-darwin" | ||
| os: macos-latest |
There was a problem hiding this comment.
while we're at it, what about adding arm64 too?
There was a problem hiding this comment.
Great call! I have considered this too.
Unfortunately, GitHub Actions don't offer GitHub-hosted macOS runners on Apple Silicon yet. This feature is currently planned for Q4 2023 - see github/roadmap#528
I don't think we can run arm64 binaries on x64 machines, can we?
There was a problem hiding this comment.
Right, makes sense! Let's wait :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have platform-specific code in
zinniadthat should be tested on macOS too.See #75