fix: rework JS tests + fix timers impl #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
changed the title
bajtos
commented
Feb 13, 2023
| ); | ||
|
|
||
| js_tests!(globals_tests); | ||
| js_tests!(timers_tests); |
There was a problem hiding this comment.
Hard-coding the list of test files in the Rust source allows the VS Code extension to understand that each JS file is a standalone integration test. As a result, we get "Run Test" and "Debug" actions rendered in the IDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Runtime Web API tests - move all test code into external JavaScript files and rework the test runner to simply execute those files. This is the first step on a longer journey - I'd like to add more structure to these test files at some point in the future, e.g. using
Deno.testor something similar.After this change, the
setTimeouttest started to fail - the callback was never invoked!As part of the change, I am also fixing that bug.