Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): correct keyActualValue and keyExpectedValue for maxItems validation #7328

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix(query): correct keyActualValue and keyExpectedValue for maxItems validation #7328

merged 1 commit into from
Feb 3, 2025

Conversation

ArturRibeiro-CX
Copy link
Contributor

Reason for Proposed Changes

  • Actual and Expected values are swapped.

Proposed Changes

  • Swap Actual and Expected values on query results.

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the query New query feature label Feb 3, 2025
@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Feb 3, 2025
@ArturRibeiro-CX ArturRibeiro-CX added the openapi OpenAPI query label Feb 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

kics-logo

KICS version: v2.1.4

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review February 3, 2025 15:33
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner February 3, 2025 15:33
EduardoSemanas
EduardoSemanas approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-ruiaraujo
cx-ruiaraujo approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArturRibeiro-CX ArturRibeiro-CX merged commit 4297cc0 into master Feb 3, 2025
26 checks passed
@ArturRibeiro-CX ArturRibeiro-CX deleted the AST-70809-value_and_expected_value_swapped branch February 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduardoSemanas EduardoSemanas EduardoSemanas approved these changes

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo approved these changes

Assignees

@ArturRibeiro-CX ArturRibeiro-CX

Labels
openapi OpenAPI query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArturRibeiro-CX @EduardoSemanas @cx-ruiaraujo