Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(password): fix Password and Secrets FP results #7353

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented Feb 27, 2025

Reason for Proposed Changes:

  • Address false positives in the Passwords and Secrets query caused by specific patterns.

Proposed Changes:

  • Added 4 new Allow Rules to handle common password retrieval cases and Terraform type object definitions:
    • Allow passwords retrieved from Terraform data sources (Azure Key Vault Secrets);
    • Allow passwords retrieved from AWS KMS Secrets;
  • Included positive and negative test cases to ensure the query behaves as expected;
  • Updated dependencies to resolve an SCA vulnerability.

I submit this contribution under the Apache-2.0 license.

@ArturRibeiro-CX ArturRibeiro-CX added the query New query feature label Feb 27, 2025
@ArturRibeiro-CX ArturRibeiro-CX self-assigned this Feb 27, 2025
@github-actions github-actions bot removed the query New query feature label Feb 27, 2025
Copy link
Contributor

github-actions bot commented Feb 27, 2025

kics-logo

KICS version: v2.1.5

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@github-actions github-actions bot added query New query feature terraform Terraform query azure PR related with Azure Cloud aws PR related with AWS Cloud labels Mar 6, 2025
@ArturRibeiro-CX ArturRibeiro-CX added bug Something isn't working and removed terraform Terraform query aws PR related with AWS Cloud azure PR related with Azure Cloud labels Mar 6, 2025
@github-actions github-actions bot removed the bug Something isn't working label Mar 6, 2025
@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review March 6, 2025 07:44
@ArturRibeiro-CX ArturRibeiro-CX requested a review from a team as a code owner March 6, 2025 07:44
@github-actions github-actions bot added terraform Terraform query azure PR related with Azure Cloud labels Mar 6, 2025
@github-actions github-actions bot added the aws PR related with AWS Cloud label Mar 6, 2025
EduardoSemanas
EduardoSemanas previously approved these changes Mar 6, 2025
Copy link
Contributor

@EduardoSemanas EduardoSemanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud azure PR related with Azure Cloud query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants