Skip to content

Breaking: Rework firewall management #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 14, 2025

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Apr 9, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #751

What is the new behavior?

  • The agent role now has a reduced firewall management. It enables default use cases, but does not try to replace proper firewall management roles. These changes are breaking and require user attention.
  • The server role now consistently manages the firewall across Debian, RedHat and Suse. This change should not be breaking, but better double check your configuration.

Other information

@robin-checkmk robin-checkmk added the role:agent This affects the agent role label Apr 9, 2025
@robin-checkmk robin-checkmk self-assigned this Apr 9, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 9, 2025
@robin-checkmk robin-checkmk force-pushed the breaking/overhaul-firewall-mgmt branch 2 times, most recently from ac58058 to e0be299 Compare May 27, 2025 10:15
@github-actions github-actions bot added the role:server This affects the server role label May 27, 2025
@robin-checkmk robin-checkmk changed the title Rework firewall management Breaking: Rework firewall management Jun 4, 2025
@robin-checkmk robin-checkmk force-pushed the breaking/overhaul-firewall-mgmt branch from a7c3dfc to dc9b4e3 Compare June 30, 2025 08:06
@robin-checkmk robin-checkmk force-pushed the breaking/overhaul-firewall-mgmt branch from deed9a3 to f29d208 Compare July 4, 2025 15:30
@robin-checkmk robin-checkmk marked this pull request as ready for review July 7, 2025 09:14
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from my perspective

@robin-checkmk robin-checkmk merged commit 6882cb9 into devel Jul 14, 2025
9 checks passed
@robin-checkmk robin-checkmk deleted the breaking/overhaul-firewall-mgmt branch July 14, 2025 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2025
@robin-checkmk robin-checkmk restored the breaking/overhaul-firewall-mgmt branch July 14, 2025 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEED] Issue with default checkmk_agent_server_ips variable behavior
3 participants