-
Notifications
You must be signed in to change notification settings - Fork 69
Breaking: Rework firewall management #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrinco
reviewed
May 21, 2025
ac58058
to
e0be299
Compare
rrinco
approved these changes
May 27, 2025
a7c3dfc
to
dc9b4e3
Compare
deed9a3
to
f29d208
Compare
lgetwan
approved these changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine from my perspective
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation
Improvements or additions to documentation
role:agent
This affects the agent role
role:server
This affects the server role
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #751
What is the new behavior?
agent
role now has a reduced firewall management. It enables default use cases, but does not try to replace proper firewall management roles. These changes are breaking and require user attention.server
role now consistently manages the firewall across Debian, RedHat and Suse. This change should not be breaking, but better double check your configuration.Other information