Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for classic signature requirements pipeline #115

Merged
merged 8 commits into from
Apr 1, 2024
Merged

test: add unit tests for classic signature requirements pipeline #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a1b3158
Adjustments to release library as open source 🚀 (#107)
fazzatti Mar 28, 2024
4bc8b70
fix: setoptions op threshold requirement
fazzatti Apr 1, 2024
562cb22
fix: revoke operation variants threshold calculation
fazzatti Apr 1, 2024
20ad502
test: add unit tests to classig sign requirements pipeline
fazzatti Apr 1, 2024
e67ac36
Merge branch 'develop' into classic-sign-req-unit-tests
fazzatti Apr 1, 2024
0ee6aef
refactor: rearrange as per aaa pattern
fazzatti Apr 1, 2024
f06b532
Merge branch 'classic-sign-req-unit-tests' of https://github.com/Chee…
fazzatti Apr 1, 2024
65daa78
Merge branch 'develop' into classic-sign-req-unit-tests
fazzatti Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/stellar-plus/core/pipelines/classic-sign-requirements/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class ClassicSignRequirementsPipeline extends ConveyorBelt<

let thresholdLevel = SignatureThreshold.medium

switch (operation.type) {
switch (operation.type as string) {
case xdr.OperationType.createAccount().name:
return {
publicKey: setSourceSigner(operation.source),
Expand Down Expand Up @@ -121,11 +121,11 @@ export class ClassicSignRequirementsPipeline extends ConveyorBelt<

case xdr.OperationType.setOptions().name:
if (
!(operation as Operation.SetOptions).masterWeight &&
!(operation as Operation.SetOptions).signer &&
!(operation as Operation.SetOptions).lowThreshold &&
!(operation as Operation.SetOptions).medThreshold &&
!(operation as Operation.SetOptions).highThreshold
(operation as Operation.SetOptions).masterWeight ||
(operation as Operation.SetOptions).signer ||
(operation as Operation.SetOptions).lowThreshold ||
(operation as Operation.SetOptions).medThreshold ||
(operation as Operation.SetOptions).highThreshold
) {
thresholdLevel = SignatureThreshold.high
}
Expand All @@ -150,7 +150,7 @@ export class ClassicSignRequirementsPipeline extends ConveyorBelt<
case xdr.OperationType.accountMerge().name:
return {
publicKey: setSourceSigner(operation.source),
thresholdLevel,
thresholdLevel: SignatureThreshold.high,
}

case xdr.OperationType.manageData().name:
Expand Down Expand Up @@ -190,6 +190,13 @@ export class ClassicSignRequirementsPipeline extends ConveyorBelt<
}

case xdr.OperationType.revokeSponsorship().name:
case 'revokeAccountSponsorship':
case 'revokeTrustlineSponsorship':
case 'revokeOfferSponsorship':
case 'revokeDataSponsorship':
case 'revokeClaimableBalanceSponsorship':
case 'revokeLiquidityPoolSponsorship':
case 'revokeSignerSponsorship':
return {
publicKey: setSourceSigner(operation.source),
thresholdLevel,
Expand Down
Loading