update code #1
Merged
update code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ádám Barancsuk <adam.barancsuk@gmail.com> Co-authored-by: Ryan Hamley <ryan.hamley@mapbox.com>
…Z to debug tile text (#7314)
…y with Mapbox Studio
…tion for essential animations (#8883)
* support generateId option in clustered sources * add a unit test for generateId clustered
* open popup on a marker from keyboard * arrow functions don't need to bind this * set tabindex on marker elements with popups and remove keypress listener * aria-label on default marker * tabindex value should be string, thanks flow * flow * flow * KeyboardEvent.charCode and keyCode are deprecated, support standard KeyboardEvent.code * add unit test for opening popup on Enter * add unit test for opening popup on Space * retain existing tabindex * fix lint * fix flow * _onKeyPress method * fix scrolling issue when focusing markers * prevent marker focus on click
* [wip] addcontains method, but trouble with wrapped coordinates * tests for contains point * lint fixes * remove comment * Update src/geo/lng_lat_bounds.js * minor lint / style fixes * fix docstring
* Introduce 'gpuTiming' map options. Originally implemented by Chris. I've rebased it and exposed it with just the event listeners instead of a map option. Listen to `gpu-timing-frame` to get the gpu time for the frame and listen to `gpu-timing-layer` to get the gpu time for all individual layers. It is not recommended to listen to both. * fixup
Co-authored-by: Ansis Brammanis <ansis@mapbox.com>
#9509) Updated the style specification compatibility tables for Android map SDK v9.1.0, iOS map SDK v5.8.0, and macOS map SDK v0.15.0.
* Add regression test for #9518 * More thorough input checks for isPatternMissing function Fixes regression introduced by #9380 ResolvedImage.fromString may now return null, which potentially leaves CrossFaded<ResolvedImage> with missing image patterns I have traced other code paths using ResolvedImage.fromString and have not seen any other potential offenders
Trick to mimic an outline with a different color.
This test should be ignored because the rendering result is wrong.
* - Add a build-time check for style-spec referencing external files - Refactor within to NOT import external files * Address review comments
…son (#9550) * More explicit files property in package.json To prevent potential upload error when publishing to npm Refer https://docs.npmjs.com/files/package.json\#files * Add a way to diff the new tarball content with previously published version This is intended to be used as part of our release process before publishing to NPM --dry-run is a useful step, but can be fairly noisy, yarn run v1.21.1 to go along the fake deploy and more clearly shows what would be added and deleted * Run the diff as part of prepublishOnly * Prompt to ensure user check before going further with publishing when running 'npm publish'
* Clean check in prepublishOnly Runs clean check as a first step in prepublishOnly. This ensures a clean directory before building the build content and before the manual diffing with previously published tarball. * Address comments
Various documentation enhancements from the docs sprints: * [docsprint] Clarify meaning of Map#isSourceLoaded (#9589) * [docsprint] Add geolocate trigger example (#9552) * [docsprint] Add inline snippet to marker#addTo (#9592) * [docsprint] Add inline snippet and related examples to popup.setHTML (#9538) * add inline snippet and related examples to popup.setHTML * update see URLs to docs subdomain * Add inline and related example for panTo (#9547) * Add inline snippet to LngLatBounds.contains (#9548) * [docsprint] Add inline snippet and examples to map.jumpTo (#9549) * add inline snippet and examples to map.jumpTo * minor reorder to match options and text * added inline and tutorial examples for map.getCenter (#9551) * add example for Marker class setLngLat (#9553) * added examples to get- and setLayoutProperty (#9554) * add inline snippet and examples to map.triggerRepaint (#9555) * CameraOptions - update pitch and bearing definitions, add inline code example, add example links (#9556) * add inline code snippet to map.showTileBoundaries (#9557) * Mark Debug namespace as private to hide it from the docs (#9558) * [docsprint] Add detail to docs on setFeatureState, removeFeatureState, getFeatureState (#9559) * add detail to docs on setFeatureState, removeFeatureState, getFeatureState * remove trailing spaces * [docsprint] map.on: remove extra on section, link to event types, add code snippet, add related (#9560) * add examples to open and close popup events (#9565) * [docsprint] Clarify how map.moveLayer works (#9566) * clarify how map.moveLayer works * fix id capitalization * [doscprint] add links to EPSG and minor example changes for LngLat (#9570) * add links to EPSG and minor example changes for LngLat * document the layer object's properties in addLayer (#9571) * [docsprint] Add inline snippet and examples to popup.addTo (#9572) * added inline example to popup-addto * added relevant examples to popup.addto * Add inline example for trackPointer (#9575) * Add inline example for Popup#getElement (#9576) * [docsprint] Add inline examples for Point & PointLike types (#9577) * Add inline examples for Point & PointLike types * Correct syntax * [docsprint] Cleanup doc for MapBoxZoomEvent (#9564) * Describe map style object returned by Map#getStyle (#9579) * [docsprint] Add inline example for getClusterLeaves (#9580) * [docsprint] PaddingOptions - update definition, example, and related (#9581) * PaddingOptions - update definition, example, and related * Fixes formatting issues * [docsprint] Add inline snippet to marker#setPopup, marker#getPopup, and marker#togglePopup (#9582) * update setPopup * update togglePopup * update formatting * update setFilter jsdoc (#9586) * add more details to getSource (#9587) * add clearStorage example (#9588) * [docsprint] Add documentation for RequestParameters (#9573) * [docsprint] Add inline example for setZoomRate and setWheelZoomRate of scrollZoomHandler (#9593) * Add inline example for setZoomRate of scrollZoomHandler * add setWheelZoomRate inline example * Add inline examples for map zoom-related methods (#9594) * [docsprint] Add example to MapMouseEvent (#9595) * add example to MapMouseEvent * Add examples for GeolocateControl events (#9596) * [docsprint] Add example to MapDataEvent (#9597) * add example to MapDataEvent * add example for getLngLat (#9591) * suggested edits for clarifying mouse events * Small grammar fix: "optional the `layerId`" -> "the optional `layerId" * Update pitch param definition; add Display buildings in 3D example * remove example object, light formatting and copyediting Co-Authored-By: Dan Swick <dan.swick@gmail.com> Co-authored-by: Adriana Babakanian <adriana.babakanian@mapbox.com> Co-authored-by: Sam Fader <samfader@users.noreply.github.com> Co-authored-by: Heather Stenson <heather.stenson@mapbox.com> Co-authored-by: Katy DeCorah <decorah@mapbox.com> Co-authored-by: jbranigan <john.branigan@mapbox.com> Co-authored-by: Jeremy Stratman <jstratman@users.noreply.github.com> Co-authored-by: Mal Wood-Santoro <mal.wood@mapbox.com> Co-authored-by: Asheem Mamoowala <asheem.mamoowala@mapbox.com> Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> Co-authored-by: geografa <geografa@users.noreply.github.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: David Wicks <david.wicks@mapbox.com> Co-authored-by: Deven Diliberto <deven.diliberto@mapbox.com> Co-authored-by: Colleen <colleen.j.mcginnis@gmail.com> Co-authored-by: Karim Naaji <karim.naaji@gmail.com>
* Pull changelog from v1.10.0 in master * Add stylespec CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes@mapbox/gl-nativeif this PR includes shader changes or needs a native port