Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: IRecognitionException should extend 'Error' #1850

Merged
merged 1 commit into from
Aug 29, 2022
Merged

docs: IRecognitionException should extend 'Error' #1850

merged 1 commit into from
Aug 29, 2022

Conversation

benhohner
Copy link
Contributor

IRecognitionException doesn't extend Error, so for example

parserInstance.errors[0].stack

is not recognized by typescript.

@benhohner
Fix Typing Error in IRecognitionException
d511a42 
`IRecognitionException` doesn't  extend `Error`, so for example
```parserInstance.errors[0].stack```
is not recognized by typescript.
@benhohner
Copy link
Contributor Author

Example of what I'm talking about available here:
https://codesandbox.io/s/happy-feather-jepi7f?file=/src/components/parser.ts:1513-1535

@bd82 bd82 changed the title Fix Typing Error in IRecognitionException docs: IRecognitionException should extend 'Error' Aug 29, 2022
@bd82
Copy link
Member

bd82 commented Aug 29, 2022

Thanks @benhohner 👍

@bd82 bd82 merged commit 8096a8a into Chevrotain:master Aug 29, 2022
@benhohner benhohner deleted the patch-1 branch September 12, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benhohner @bd82