feat: add context argument to recoveryValueFunc #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nupthale 👍 |
|
Thanks, by the way , when will this feature be released？ @bd82 |
|
hopefully on the weekend |
|
ok, Thanks |
|
sorry to bother😅, when will this feature be released？ @bd82 |
bd82
changed the title
|
Hi @nupthale Sorry, I was not available for a while... |
|
version 10.5.0 is out on npm |
sidharthv96
added a commit
to sidharthv96/chevrotain
that referenced
this pull request
Jun 5, 2023
* upstream/master: chore(deps): update prettier chore(release): release v10.5.0 chore: update changelog before release feat: add IRecognitionException to recoveryValueFunc arguments to provide information (Chevrotain#1917)
martin-fleck-at
added a commit
to CrossBreezeNL/crossmodel
that referenced
this pull request
Aug 29, 2023
- Downgrade from 10.5.0 to 10.4.2 as it does not work for our YAML lang -- Chevrotain/chevrotain@v10.4.2...v10.5.0 -- Main extension: Chevrotain/chevrotain#1917
martin-fleck-at
added a commit
to CrossBreezeNL/crossmodel
that referenced
this pull request
Aug 29, 2023
- Downgrade from 10.5.0 to 10.4.2 as it does not work for our YAML lang -- Chevrotain/chevrotain@v10.4.2...v10.5.0 -- Main extension: Chevrotain/chevrotain#1917
harmen-xb
added a commit
to CrossBreezeNL/crossmodel
that referenced
this pull request
Oct 18, 2023
* New examples, + moving old examples around * Does not work good enough yet, but it work enough to keep going * Implemented testing for new language * GmodelFactory refactor, serailizer broken, fixing that first * Rewrote serializer, now dynamic and works with Yaml * GModel-factory now works with new lang * Extension should be working with new language * Fix error about character needing to be non-negative caused by '-1' * Fix errors by using a specific chevrotain version - Downgrade from 10.5.0 to 10.4.2 as it does not work for our YAML lang -- Chevrotain/chevrotain@v10.4.2...v10.5.0 -- Main extension: Chevrotain/chevrotain#1917 * To get it working on my machine * readme update for license * fixing tests * Improve stability of cross-updates and fix edge structure - Ensure edges (relationships) are created between nodes (entities) -- Ensure node entity matches expected relationship entity - Improve stability of cross-updates -- Ensure 'save' does an implicit 'update' of the internal structure -- Ensure update only updates text editor when it was opened -- Only do full textual updates to avoid merging issues -- Let UI react to updates, not only on save -- Debounce model update for form editor - Minors -- Adapt grammar to better reflect semantic element (instead of 'for') -- Always serialize properties in same order * Update example files and fix IDs for GLSP server for better update * Extend protocol with client id and improve update mechanism - Use open/close as lifecycle methods for clients - Let extension startup early to handle non-textual editors * Fixed wrong use of name vs name_val when showing and synching the model. * Added missing name property on Order entity. * Initial gitpod setup. * Added yarn test in build action. * Refactored test build part into seperate action and added in feature build only (for now). * Disabled test action for now, since it doesn't seem to work on GitHub easily. * Refactored serializer so indentation and characters used are in constants. Updated/added some comments. Updated model-service-impl so have more specific console/promise messages and added some comments. --------- Co-authored-by: Özcan Seker <ozcan@x-breeze.com> Co-authored-by: Harmen Wessels <harmen@x-breeze.com> Co-authored-by: Harmen Wessels <97173058+harmen-xb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the EmbeddedActionsParser with recoveryEnabled to generate my own AST nodes.
I want some range information about the recoveryNode to generete the errorNode, but now i've got no place to find the range information.
I hope it'll provide some context information about the error when calling custom recoveryValueFunc.