Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code, deny unsafe and fix clippy errors #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aloso
Copy link
Contributor

@Aloso Aloso commented Oct 31, 2020

This PR

  • Reformats everything with cargo fmt. This is generally recommended in open-source projects, as it enforces a consistent style. Also, rust-analyzer runs cargo fmt by default every time a file is saved, so having to disable it for this repository is inconvenient.

    Note that a few parts of the code are less readable than before, but I think the gained consistency is worth it. It might be possible to improve readability by extracting expressions into new variables.

  • Disables some clippy lints, so cargo clippy produces no warnings or errors.

  • Adds #[deny(unsafe_code)], since this crate doesn't require unsafe.

@ChevyRay
Copy link
Owner

ChevyRay commented Nov 2, 2020

will merge this soon, probably. just need to find time to look it over and also learn about whatever clippy is lol

@Aloso
Copy link
Contributor Author

Aloso commented Nov 9, 2020

@ChevyRay any progress?

(clippy is a linter that detects common mistakes, see https://rust-lang.github.io/rust-clippy/stable/index.html)

@ChevyRay
Copy link
Owner

ChevyRay commented Nov 9, 2020

like i said, when i find time to look it over and learn about what clippy is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants