Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JDA 5.0.0-alpha.18 (Message Refactor) #76

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

Andre601
Copy link

Pull Request

Pull Request Checklist

Please follow the following steps before opening this PR.

PRs that do not complete the checklist will be subject to denial for
missing information.

Pull Request Information

Check and fill in the blanks for all that apply:

  • My PR fixes a bug, error, or other issue with the library's codebase.
  • My PR is for the command and menu module of the JDA-Chewtils library.
  • My PR creates a new module for the JDA-Chewtils library: ______.

Description

Updates Chewtils to support the latest Message changes made in JDA v5.
Methods using Message instances as vars (i.e. reply(Message)) have been updated to use MessageCreateData instances instead.

respond(File, String, AttachmentOption...) was changed to respond(File, String, String, boolean) due to AttachmentOption being removed.
The new method now uses the second String for the description (Set to null or empty for no description) and the boolean to mark as spoiler.

I'll leave this PR as a draft until the next Alpha is dropped by JDA that implements it completely, so that we have a proper version to support and not just a commit.
(I mainly made this change to use it in my bot :P)

@Chew
Copy link
Owner

Chew commented Aug 19, 2022

I started on this but gave up, thanks for takin over 😄

@Andre601 Andre601 marked this pull request as ready for review August 21, 2022 20:18
@Andre601
Copy link
Author

Guess the new version requires to propagate first...

@Chew
Copy link
Owner

Chew commented Aug 21, 2022

Yeah it can take an hour or so, welcome to central

@Chew
Copy link
Owner

Chew commented Aug 21, 2022

Nevermind, that's not the issue 😄

build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Olivia <chew@chew.pw>
@Chew Chew changed the title Support for JDA v5's Message update Support for JDA 5.0.0-alpha.18 (Message Refactor) Aug 22, 2022
@Chew Chew merged commit 7fca7c8 into Chew:master Aug 22, 2022
@Andre601 Andre601 deleted the feature/jda-message-update-support branch August 22, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants