Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell: renamed all Number functions to align with new findings #11

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

hollowaykeanho
Copy link
Member

It's better to have the type comes after the library name like 'HestiaKERNEL_ERROR...' or 'HestiaKERNEL_OS...' function names and filepaths. That way, it's less learning yet tracable by reading. Hence, let's deal with all the Number functions.

This patch renames all Number functions to align with new findings in Shell/ directory.

It's better to have the type comes after the library name like
'HestiaKERNEL_ERROR...' or 'HestiaKERNEL_OS...' function names
and filepaths. That way, it's less learning yet tracable by
reading. Hence, let's deal with all the List functions.

This patch renames all List functions to align with new findings
in Shell/ directory.

Co-authored-by: Shuralyov, Jean <jean.shuralyov@proton.me>
Co-authored-by: Galyna, Cory <cory.galyna@gmail.com>
Co-authored-by: (Holloway) Chew, Kean Ho <me@hollowaykeanho.com>
Signed-off-by: (Holloway) Chew, Kean Ho <me@hollowaykeanho.com>
@hollowaykeanho hollowaykeanho self-assigned this Dec 27, 2024
Copy link
Contributor

@corygalyna corygalyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@hollowaykeanho hollowaykeanho merged commit 1c3541f into next Dec 27, 2024
3 checks passed
@ChewKeanHo ChewKeanHo locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants