Shell: added Is_Command_* functions suite #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Is_Command_* functions suite was accidentally ported, it's better to commit it in. Hence, let's do this. This patch adds Is_Command_* functions suite into Shell/ directory. Co-authored-by: Shuralyov, Jean <jean.shuralyov@proton.me> Co-authored-by: Galyna, Cory <cory.galyna@gmail.com> Co-authored-by: (Holloway) Chew, Kean Ho <me@hollowaykeanho.com> Signed-off-by: (Holloway) Chew, Kean Ho <me@hollowaykeanho.com>
corygalyna
approved these changes
Dec 26, 2024
|
In noticed the directory name placement in the function name has changed. Will that affects the existing functions like String and etc? |
Yes. Next few patches would be re-naming. For |
|
Ok proceed to merge. I will wait for those patches before 2am. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Is_Command_* functions suite was accidentally ported, it's better to commit it in. Hence, let's do this.
This patch adds Is_Command_* functions suite into Shell/ directory.