Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit config, GitHub Actions (GEN-279) #2

Closed
wants to merge 3 commits into from

Conversation

sritchie
Copy link
Contributor

This PR:

  • adds .pre-commit-config.yaml with hooks for ruff, pyright and other various helpful tidying tasks
  • adds a separate ruff github action, so ruff linting callouts are added to the GitHub PR view
  • pyright runs in a separate action (not pre-commit.ci) so that we can set up the poetry venv correctly (we can't do this on the pre-commit.ci server)
  • makes the first batch of automatic fixes suggested by the pre-commit hooks

@sritchie sritchie requested a review from mhuebert June 13, 2024 01:21
@sritchie
Copy link
Contributor Author

@mhuebert it would be great to get the tests in CI as well! Take a look at the errors... the remaining ruff errors look like real bugs, yeah?

@sritchie sritchie changed the title Add pre-commit config, GitHub Actions Add pre-commit config, GitHub Actions (GEN-279) Jun 13, 2024
Copy link

linear bot commented Jun 13, 2024

GEN-279 Add pre-commit hooks for Ruff, Pyright to GenStudio

We should get the same affordances that we have at GenJAX.

@mhuebert
Copy link
Collaborator

Thanks! I have merged these changes here: #5

@mhuebert mhuebert closed this Jun 18, 2024
@mhuebert mhuebert deleted the sritchie/pre_commit branch June 18, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants