[RFC] Make credible test set in .spec files and get everything passing according to new bls api #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqk
approved these changes
Jul 20, 2021
| }; | ||
| } | ||
|
|
||
| // Values lifted from test.js, which is ported from test.py and is a more |
|
@mariano54 can you take a look at these BLS tests? |
UdjinM6
pushed a commit
to UdjinM6/bls-signatures
that referenced
this pull request
Dec 1, 2021
…g according to new bls api (Chia-Network#252) * Make credible test set in .spec files and get everything passing accoring to new bls api * oops needed this for the other test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the ci runnable test set up to date with the current API of bls-signatures as made in the python bindings and reproduced in jsbindings.cpp.
PublicKey and Signature became G1Element and G2Element
Signature lost aggregation info and its associated methods
Aggregation related methods in Signature and PublicKey became scheme specific in BasicSchemeMPL, AugSchemeMPL and PopSchemeMPL (aggregate, aggregate_verify).
Key seed picked up the requirement of being at least 32-bytes in length and changed salt string
PublicKey and Signature picked up requirement of having the first bit set in a serialized value
I've preserved as much of the spirit of the original as possible and used existing test byte data where possible.
Karma has updated significantly in the interim and runs webpack differently, so some updating and adjustment were required for the browser side test run.