Fix timelord closing. #10630
Merged
Fix timelord closing. #10630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs a look @mariano54 |
mariano54
reviewed
Mar 31, 2022
| if chain not in self.unspawned_chains: | ||
| self.unspawned_chains.append(chain) | ||
| if chain in self.chain_type_to_stream: | ||
| del self.chain_type_to_stream[chain] | ||
| del self.chain_type_to_stream[chain] |
There was a problem hiding this comment.
we are not checking inclusion anymore. Is that intentional?
There was a problem hiding this comment.
it should always be included at this point - in case it's not we have no writer to close, it'll just log the error (but I don't think it ever gets to this point).
| @@ -183,25 +183,22 @@ async def _handle_client(self, reader: asyncio.StreamReader, writer: asyncio.Str | |||
|
|
|||
| async def _stop_chain(self, chain: Chain): | |||
| try: | |||
| while chain not in self.allows_iters: | |||
There was a problem hiding this comment.
Why are we removing the while loop?
There was a problem hiding this comment.
to avoid the infinite loop that happens in rare cases (written in the description).
mariano54
approved these changes
Mar 31, 2022
emlowe
pushed a commit
that referenced
this pull request
Apr 21, 2022
justinengland
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the infinite loop
Trying to stop {chain} before its initialization.if we try to close a chain that's not inself.allow_iters.