farmer: Introduce UPDATE_POOL_INFO_FAILURE_RETRY_INTERVAL
#11076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retry to load the pool info with a 2 minutes interval if it failed.
xdustinface
force-pushed
the
pr-farmer-reduce-pool-info-timeout
branch
from
1b13582 to
2236cf7
Compare
xdustinface
changed the title
UPDATE_POOL_INFO_INTERVAL from 3600 to 300UPDATE_POOL_INFO_FAILURE_RETRY_INTERVAL
aqk
reviewed
Apr 11, 2022
| @@ -479,6 +480,8 @@ async def update_pool_state(self): | |||
| # Only update the first time from GET /pool_info, gets updated from GET /farmer later | |||
| if pool_state["current_difficulty"] is None: | |||
| pool_state["current_difficulty"] = pool_info["minimum_difficulty"] | |||
| else: | |||
| pool_state["next_pool_info_update"] = time.time() + UPDATE_POOL_INFO_FAILURE_RETRY_INTERVAL | |||
There was a problem hiding this comment.
Were you able to try this for the pool_info is None case and the "error_code" not in pool_info case?
There was a problem hiding this comment.
Nope, we need pool tests :/ But it's pretty obvious actually and only affects the failure case.
aqk
approved these changes
Apr 11, 2022
|
This might result in quite a log of retries if the failure isn't transient - maybe the pool has a problem, and the client will retry every 2 mins. |
Hm, i don't feel like a log every 2 minutes is too bad if something is wrong. |
emlowe
pushed a commit
that referenced
this pull request
Apr 21, 2022
Retry to load the pool info with a 2 minutes interval if it failed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry to load the pool info with a 2 minutes interval if it failed.