replace some asyncio.get_event_loop().run_until_complete() with asyncio.run() #11131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdustinface
suggested changes
Apr 12, 2022
|
There was some funny business there where the fact we were doing silly stuff actually caused problems when doing it a bit less silly. I'm punting on that for the sake of getting 3.10 done. There's a warning ignore added related to those so they are 'on a list' as needing to be addressed. Sort of. |
xdustinface
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
There was some funny business there where the fact we were doing silly stuff actually caused problems when doing it a bit less silly.
Hm, ok but i don't really understand whats different in there and what kind of "funny business" would lead to an issue since it works just fine (at least locally).
emlowe
pushed a commit
that referenced
this pull request
Apr 21, 2022
emlowe
added
1.3.5-cherrypick
and removed
ready_to_merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #9930.