Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Some rollback fixes #11149

Merged
merged 3 commits into from
Apr 20, 2022
Merged

wallet: Some rollback fixes #11149

merged 3 commits into from
Apr 20, 2022

Conversation

xdustinface
Copy link
Contributor

Note that im not super familiar yet with all the surrounding code/workflows so, review well :)

  • 31a86d4 Pretty sure this is needs to be applied but not sure if those calls even raise in practice
  • b3763cb and b16a2c5 Not sure if they are really needed or if the block records and wallet would also just recover in some other way if they are removed but the DB transaction rolled back

@xdustinface xdustinface requested review from mariano54 and Yostra April 13, 2022 01:57
mariano54
mariano54 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@mariano54 mariano54 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The commits are needed, failing and rolling back but not having the block records can be bad

@mariano54 mariano54 added the ready_to_merge Submitter and reviewers think this is ready label Apr 13, 2022
@wjblanke wjblanke merged commit cd9beac into Chia-Network:main Apr 20, 2022
emlowe pushed a commit that referenced this pull request Apr 21, 2022
@xdustinface @emlowe
wallet: Some rollback fixes (#11149)
1435f6c 
* Set `in_transaction` for `set_finished_sync_up_to`

* Call `clean_block_records` based on `in_transaction`

* Don't pop wallets in `reorg_rollback`, do it after it was commited
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariano54 mariano54 mariano54 approved these changes

@Yostra Yostra Awaiting requested review from Yostra

Assignees
No one assigned
Labels
ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xdustinface @mariano54 @wjblanke