Check observer addresses in farm rewards dialog #11259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano54
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Thanks for doing this, it's a good cleanup.
The performance of this can also be optimized significantly, by doing the same thing as init funcs and keeping the intermediate values:
https://github.com/Chia-Network/chia-blockchain/blob/main/chia/cmds/init_funcs.py#L96
master_sk_to_wallet_sk repeats a lot of work (3/4 of the derivations are being done over and over)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI farmer rewards check was not checking for observer keys and the code was duplicated from farmer and wallet, which is one reason this was missed.
Consolidated some code into new function called by both the wallet and farmer and added tests for observer keys.
Also added the ability to pass in the number of derivations to the RPC call - primarily this was so the tests can pass in much smaller numbers than the default (500) and so the tests can run much faster. However, this flexibility seems worth while regardless
(new PR because git hates me, but it is mutual)
Fixes #11036