farmer|gui: Enable paginated plot loading and improved state reporting #11367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
xdustinface
force-pushed
the
pr-improved-farm-gui
branch
from
e920e70 to
bbcae57
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
- Only send the data for the harvester which actually sent an update - Notify for each loaded batch during initial loading
xdustinface
force-pushed
the
pr-improved-farm-gui
branch
from
bbcae57 to
4c03c9b
Compare
|
70679c1 is ready for review but GUI will probably receive another update in a bit with small style changes. |
altendky
previously approved these changes
May 3, 2022
xdustinface
force-pushed
the
pr-improved-farm-gui
branch
from
4c03c9b to
be9a6de
Compare
xdustinface
added a commit
that referenced
this pull request
May 4, 2022
#11367) * farmer: Adjust notifications from the farmer to the UI - Only send the data for the harvester which actually sent an update - Notify for each loaded batch during initial loading * Enable improved farmer/harvester GUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the new GUI and changes the event which gets sent from the farmer to the GUI which was previously called
new_plotswith the payload ofget_harvesterswith the plots of all harvesters.Now with this PR the event gets renamed to
harvester_updateand it:get_harvester_summay) for the harvester which actually sent an updateThere is also a new state changed event called
harvester_removedwhich gets triggered by the farmer if the harvester was disconnected and has the payload{"node_id": <node_id of the harvester which was removed>}Based on #11342 and required #11365