Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #11393

Merged
merged 2 commits into from
May 5, 2022
Merged

Update CONTRIBUTING.md #11393

merged 2 commits into from
May 5, 2022

Conversation

mariano54
Copy link
Contributor

No description provided.

@mariano54 mariano54 requested a review from altendky May 2, 2022 16:41
altendky
altendky previously approved these changes May 2, 2022
CONTRIBUTING.md Outdated Show resolved Hide resolved
2. Install BlackConnect plugin
3. Set to run python black on save
4. Set line length to 120
5. Install the linters in the root directory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what 5. means and I personally can't comment on the rest as the closest I come to black integrations is a ctrl+b shortcut. Do you have to have the venv activated in the console where you launch pycharm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what 5 means. I just left it there since I didn't know what it meant

Prior to the release of `1.1.0` there will be two running test nets. `testnet` and `transaction-beta-testnet`. The `transaction-beta-testnet` testnet will be a beta of the pending 1.1 release, which will enable transactions on the chia blockchain.
Following the release of `1.1.0`, the official `testnet` will include all changes that have been accepted to the current release branch.
The current official testnet is testnet10. Look at `chia/util/initial_config.yaml` to see the configuration parameters
for each testnet. Information on how to use the testnet can be found in the wiki.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link to the wiki?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links change a lot so I rather avoid adding a link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, another check to add. A link checker.

Co-authored-by: Kyle Altendorf <sda@fstab.net>
@mariano54 mariano54 added the ready_to_merge Submitter and reviewers think this is ready label May 2, 2022
@wjblanke wjblanke merged commit a19f182 into main May 5, 2022
@wjblanke wjblanke deleted the ms.contributing branch May 5, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants