test: Give setup_farmer and setup_harvester a separate chia root
#11408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure the first sync from the harvester to the farmer is done before we check plot counts.
altendky
reviewed
May 3, 2022
Comment on lines
+240
to
+244
| root_config = load_config(root_path, "config.yaml") | ||
| root_config["logging"]["log_stdout"] = True | ||
| root_config["selected_network"] = "testnet0" | ||
| root_config["farmer"]["selected_network"] = "testnet0" | ||
| save_config(root_path, "config.yaml", root_config) |
There was a problem hiding this comment.
Suggested change
| root_config = load_config(root_path, "config.yaml") | |
| root_config["logging"]["log_stdout"] = True | |
| root_config["selected_network"] = "testnet0" | |
| root_config["farmer"]["selected_network"] = "testnet0" | |
| save_config(root_path, "config.yaml", root_config) | |
| with with lock_and_load_config(root_path, "config.yaml") as root_config: | |
| root_config["logging"]["log_stdout"] = True | |
| root_config["selected_network"] = "testnet0" | |
| root_config["farmer"]["selected_network"] = "testnet0" | |
| save_config(root_path, "config.yaml", root_config) |
altendky
approved these changes
May 3, 2022
xdustinface
added a commit
that referenced
this pull request
May 4, 2022
…11408) * test: Give `setup_farmer` and `setup_harvester` a separate chia root * test: Wait for `last_sync_time` in `get_harvesters_{summary}` To make sure the first sync from the harvester to the farmer is done before we check plot counts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Them sharing the same root as
BlockToolsalso leads issues in test which modify the content ofconfig.yaml.