harvester: Fix deadlock on disconnect after a repeated plot sync start #11481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
previously approved these changes
May 11, 2022
altendky
approved these changes
May 11, 2022
|
shouldn't this be included in to 1.3.5 release as well? |
|
Note that 1.3.5 was released yesterday. |
|
Tested on my 5p plots miner, very nice. Great work! @xdustinface |
|
All of my harvesters stopped connecting today on Windows. Restarting and upgrading to 1.3.5 did not help. I will try to copy the certificates from the farmer again to see if that helps. |
|
same here on 1.3.5 |
|
This PR isn't included in 1.3.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on main if the farmer/harvester connections drops after the farmer didn't respond to plot sync messages for more than the refresh interval of the harvester we end up with a harvester deadlock because the plot manager thread stucks here
chia-blockchain/chia/plot_sync/sender.py
Line 259 in a4ec7e7
while the main threads wants to join it here as part of the disconnect
chia-blockchain/chia/harvester/harvester.py
Line 107 in a4ec7e7
See the test b49ef16 which fails without the other two commits.