reusable workflow for a single test workflow #11722

altendky · 2022-06-01T00:10:43Z

Draft for:

Review redundancy between runs configuration and matrix excludes

altendky · 2022-06-01T02:01:43Z

https://github.com/Chia-Network/chia-blockchain/runs/6681164015?check_suite_focus=true

==================================== ERRORS ====================================
____________________ ERROR at setup of test_sync_duplicates ____________________
[gw2] linux -- Python 3.7.13 /home/runner/work/chia-blockchain/chia-blockchain/venv/bin/python
tests/plot_sync/test_plot_sync.py:303: in environment
    await farmer_service.start()
chia/server/start_service.py:163: in start
    await self._server.start_server(self._on_connect_callback)
chia/server/server.py:275: in start_server
    await self.site.start()
venv/lib/python3.7/site-packages/aiohttp/web_runner.py:128: in start
    reuse_port=self._reuse_port,
/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/asyncio/base_events.py:[138](https://github.com/Chia-Network/chia-blockchain/runs/6681164015?check_suite_focus=true#step:16:139)9: in create_server
    % (sa, err.strerror.lower())) from None
E   OSError: [Errno 98] error while attempting to bind on address ('0.0.0.0', 45708): address already in use

https://github.com/Chia-Network/chia-blockchain/runs/6681412035?check_suite_focus=true

================================== FAILURES ===================================
____ TestPoolWalletRpc.test_create_multiple_pool_wallets[trusted_and_fee1] ____
[gw1] win32 -- Python 3.9.13 D:\a\chia-blockchain\chia-blockchain\venv\scripts\python.exe
tests\pools\test_pool_rpc.py:374: in test_create_multiple_pool_wallets
    await time_out_assert(30, wallet_is_synced, True, wallet_node_0, full_node_api)
E   AssertionError: Timed assertion timed out after 30 seconds: expected True, got False

https://github.com/Chia-Network/chia-blockchain/runs/6681411030?check_suite_focus=true

================================== FAILURES ===================================
______ TestFileKeyringSynchronization.test_writer_lock_released_on_abort ______
[gw0] win32 -- Python 3.9.13 D:\a\chia-blockchain\chia-blockchain\venv\scripts\python.exe
tests\util\keyring.py:73: in inner
    return method(self, *args, **kwargs)
tests\core\util\test_file_keyring_synchronization.py:434: in test_writer_lock_released_on_abort
    assert lock.acquire_write_lock(timeout=(2)) is True
E   assert False is True
E    +  where False = <bound method _InterProcessReaderWriterLock.acquire_write_lock of <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x000002351C4C9BB0>>(timeout=2)
E    +    where <bound method _InterProcessReaderWriterLock.acquire_write_lock of <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x000002351C4C9BB0>> = <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x000002351C4C9BB0>.acquire_write_lock

During handling of the above exception, another exception occurred:
tests\util\keyring.py:73: in inner
    return method(self, *args, **kwargs)
tests\util\keyring.py:193: in __exit__
    self.cleanup()
tests\util\keyring.py:205: in cleanup
    shutil.rmtree(self.keychain._temp_dir)
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\shutil.py:759: in rmtree
    return _rmtree_unsafe(path, onerror)
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\shutil.py:629: in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\shutil.py:627: in _rmtree_unsafe
    os.unlink(fullname)
E   PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\test_keyring_wrapper0eqgfbqj\\.keyring.yaml.lock'

altendky · 2022-06-01T03:28:33Z

https://github.com/Chia-Network/chia-blockchain/runs/6682244657?check_suite_focus=true

================================== FAILURES ===================================
______ TestFileKeyringSynchronization.test_writer_lock_released_on_abort ______
[gw0] win32 -- Python 3.8.10 d:\a\chia-blockchain\chia-blockchain\venv\scripts\python.exe
tests\util\keyring.py:73: in inner
    return method(self, *args, **kwargs)
tests\core\util\test_file_keyring_synchronization.py:434: in test_writer_lock_released_on_abort
    assert lock.acquire_write_lock(timeout=(2)) is True
E   assert False is True
E    +  where False = <bound method _InterProcessReaderWriterLock.acquire_write_lock of <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x0000020358F0ED00>>(timeout=2)
E    +    where <bound method _InterProcessReaderWriterLock.acquire_write_lock of <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x0000020358F0ED00>> = <fasteners.process_lock._WindowsInterProcessReaderWriterLock object at 0x0000020358F0ED00>.acquire_write_lock

During handling of the above exception, another exception occurred:
tests\util\keyring.py:73: in inner
    return method(self, *args, **kwargs)
tests\util\keyring.py:193: in __exit__
    self.cleanup()
tests\util\keyring.py:205: in cleanup
    shutil.rmtree(self.keychain._temp_dir)
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\shutil.py:740: in rmtree
    return _rmtree_unsafe(path, onerror)
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\shutil.py:618: in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\shutil.py:616: in _rmtree_unsafe
    os.unlink(fullname)
E   PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\test_keyring_wrapper7odh2o5v\\.keyring.yaml.lock'

altendky · 2022-06-01T15:04:54Z

https://github.com/Chia-Network/chia-blockchain/runs/6691092193?check_suite_focus=true

================================== FAILURES ===================================
___________ TestPoolWalletRpc.test_absorb_pooling[trusted_and_fee1] ___________
[gw0] win32 -- Python 3.9.13 D:\a\chia-blockchain\chia-blockchain\venv\scripts\python.exe
tests\pools\test_pool_rpc.py:757: in test_absorb_pooling
    ret = await client.pw_absorb_rewards(2, fee)
chia\rpc\wallet_rpc_client.py:337: in pw_absorb_rewards
    reply = await self.fetch(
chia\rpc\rpc_client.py:49: in fetch
    raise ValueError(res_json)
E   ValueError: {'error': 'Cannot claim due to unconfirmed transaction. If this is stuck, delete the unconfirmed transaction.', 'success': False}

altendky · 2022-06-01T17:17:12Z

https://github.com/Chia-Network/chia-blockchain/runs/6693915522?check_suite_focus=true

=================================== FAILURES ===================================
_________________ TestDIDWallet.test_did_attest_after_recovery _________________
tests/wallet/did_wallet/test_did.py:460: in test_did_attest_after_recovery
    attest_data = (await did_wallet.create_attestment(coin.name(), new_ph, pubkey))[1]
chia/wallet/did_wallet/did_wallet.py:814: in create_attestment
    assert coins is not None and coins != set()
E   AssertionError

altendky · 2022-06-01T17:22:18Z

https://github.com/Chia-Network/chia-blockchain/runs/6693942093?check_suite_focus=true

================================== FAILURES ===================================
_________________ test_nft_wallet_creation_and_transfer[True] _________________
tests\wallet\nft_wallet\test_nft_wallet.py:184: in test_nft_wallet_creation_and_transfer
    assert len(coins) == 1, "nft not generated"
E   AssertionError: nft not generated
E   assert 0 == 1
E    +  where 0 = len([])

github-actions · 2022-06-02T02:43:05Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-06-02T13:01:33Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

wjblanke

aok

github-actions · 2022-06-03T19:27:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-06-03T19:47:26Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2022-06-03T20:05:30Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-06-03T20:15:30Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2022-06-03T20:34:35Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

emlowe

seems all good to me

altendky added 13 commits May 31, 2022 20:09

reusable workflow for a single test workflow with coverage collection

1981882

avoid needing typing-extensions to build workflow jobs

d476a6c

remove incorrect coverage job

35e697e

correct enabling of pytest-monitor

fce2c2a

$Env:GITHUB_*

77e788b

tweak concurrency

a4c69cd

add explanation for use of the reusable workflow

de5720b

name: Generate matrix configuration

2fdd2a9

correct timelord installation choice logic

b3fcc9e

avoid * to fix coverage combining on windows

b40f451

name: Configure matrix

2831404

bring back the conditional run

c9d3367

less matrix.os.matrix

5c195ff

altendky added 3 commits May 31, 2022 22:22

hmm

2b49a76

again

f057f59

exclude instead

6c9ed81

altendky added 2 commits May 31, 2022 23:49

fixup JOB_FILE_NAME

adca4f1

leave the final coverage step for later

d523c09

altendky mentioned this pull request Jun 1, 2022

Add final coverage processing to single test workflow #11725

Closed

2 tasks

altendky added 2 commits June 1, 2022 09:41

drop configuration.runs in favor of matrix excludes

f22d457

fixup os checks

97cd847

altendky changed the title ~~reusable workflow for a single test workflow with coverage collection~~ reusable workflow for a single test workflow Jun 1, 2022

actions/cache@v3

b50b7e8

altendky marked this pull request as ready for review June 1, 2022 16:08

altendky requested review from aqk, cmmarslender and emlowe June 1, 2022 16:11

altendky mentioned this pull request Jun 1, 2022

single test workflow - coverage #11315

Closed

2 tasks

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 2, 2022

Merge branch 'main' into emoci

16e9dd1

github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 2, 2022

altendky requested a review from cmmarslender June 2, 2022 19:08

cmmarslender previously approved these changes Jun 2, 2022

View reviewed changes

emlowe previously approved these changes Jun 2, 2022

View reviewed changes

wjblanke previously approved these changes Jun 3, 2022

View reviewed changes

Merge branch 'main' into emoci

45b9c3a

altendky dismissed stale reviews from wjblanke, emlowe, and cmmarslender via 45b9c3a June 3, 2022 17:54

altendky requested review from emlowe and wjblanke June 3, 2022 18:18

github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed merge_conflict Branch has conflicts that prevent merge to main labels Jun 3, 2022

github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 3, 2022

github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 3, 2022

emlowe approved these changes Jun 3, 2022

View reviewed changes

wallentx merged commit 458697b into main Jun 3, 2022

wallentx deleted the emoci branch June 3, 2022 21:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reusable workflow for a single test workflow #11722

reusable workflow for a single test workflow #11722

altendky commented Jun 1, 2022 •

edited

Loading

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

github-actions bot commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

wjblanke left a comment

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

emlowe left a comment

reusable workflow for a single test workflow #11722

reusable workflow for a single test workflow #11722

Conversation

altendky commented Jun 1, 2022 • edited Loading

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

altendky commented Jun 1, 2022

github-actions bot commented Jun 2, 2022

github-actions bot commented Jun 2, 2022

wjblanke left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

github-actions bot commented Jun 3, 2022

emlowe left a comment

Choose a reason for hiding this comment

altendky commented Jun 1, 2022 •

edited

Loading