cmds: Only access existing pool states in pprint_pool_wallet_state
#11911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdustinface
force-pushed
the
pr-fix-print-pool-wallet-state
branch
from
0f54ae5 to
da574e4
Compare
|
This is interesting - the wallet knows about this launcher_id - but it's not in config.yaml? |
I had it pulled out of my config.yaml to remove confusion since its an unusable plotnft for me. |
|
Checked this out and verified this fixed it. |
|
I'm somewhat conflicted whether this is a must-have for 1.4. AFAIK it's not a regression in 1.4 and it doesn't seem that critical. |
emlowe
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues like #11897 where the command fails if the state for the wallet with
launcher_idgets printed but thelauncher_idisn't available in the farmer's pool state list (i.e. its not in the config).Note: This moves the
Payout instructionsoutput aboveRelative lock heightto avoid needing anotherpool_state_dict is not None:)