Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DID wallet coin_added #16256

Merged
merged 7 commits into from
Oct 5, 2023
Merged

DID wallet coin_added #16256

merged 7 commits into from
Oct 5, 2023

Conversation

ytx1991
Copy link
Contributor

@ytx1991 ytx1991 commented Sep 5, 2023 •
edited
Loading

Purpose:

Prevent redundant peer call in the DID wallet.

Current Behavior:

DID will call peer API again to get coin state and coin spend.

New Behavior:

Reuse the coin state and coin spend got in the wallet manager.

Testing Notes:

@ytx1991 ytx1991 requested a review from a team as a code owner September 5, 2023 18:07
@ytx1991 ytx1991 changed the title eneccccvvhctfndteknrfcdkgcffdcbvtchngdvbtckrOptimze DID walelt coin_added DID walelt coin_added Sep 5, 2023
@ytx1991 ytx1991 self-assigned this Sep 5, 2023
@ytx1991 ytx1991 added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Sep 5, 2023
@xdustinface xdustinface changed the title DID walelt coin_added DID wallet coin_added Sep 6, 2023
@ytx1991 ytx1991 requested a review from Quexington September 7, 2023 23:03
Quexington
Quexington previously approved these changes Sep 8, 2023
View reviewed changes
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Sep 12, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Sep 13, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

xdustinface
xdustinface suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the last catch up merge messed something up here and there is one unrelated formatting change.

tests/wallet/did_wallet/test_did.py Outdated Show resolved Hide resolved
xdustinface
xdustinface reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit (isort) is still broken.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Sep 30, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

wjblanke
wjblanke approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender reopened this Oct 5, 2023
@cmmarslender cmmarslender merged commit 1249938 into main Oct 5, 2023
231 checks passed
@cmmarslender cmmarslender deleted the coin_added_did branch October 5, 2023 20:30
This was referenced Oct 28, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xdustinface xdustinface xdustinface approved these changes

@wjblanke wjblanke wjblanke approved these changes

@Quexington Quexington Quexington left review comments

Assignees

@ytx1991 ytx1991

Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ytx1991 @wjblanke @Quexington @xdustinface @cmmarslender