Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmark flakiness #16649

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Fix benchmark flakiness #16649

merged 5 commits into from
Oct 24, 2023

Conversation

fchirica
Copy link
Contributor

No description provided.

@fchirica fchirica requested a review from a team as a code owner October 18, 2023 00:00
@fchirica fchirica added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Oct 18, 2023
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 18, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 18, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn
Copy link
Contributor

arvidn commented Oct 19, 2023 •
edited
Loading

https://github.com/Chia-Network/chia-blockchain/actions/runs/6563702905/job/17828538516?pr=16649#step:13:1314

____________ test_benchmark_batch_insert_speed[pre=1000,count=1000] ____________
tests/core/data_layer/test_data_store.py:1431: in test_benchmark_batch_insert_speed
    with benchmark_runner.assert_runtime(seconds=case.limit):
E   AssertionError: 26.133334149999996 seconds not less than 24 seconds ( 109 % )

arvidn
arvidn reviewed Oct 19, 2023
View reviewed changes
.github/workflows/benchmarks.yml Outdated Show resolved Hide resolved
tests/core/full_node/test_performance.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 19, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Oct 20, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

File Coverage Missing Lines
tests/core/full_node/test_performance.py 0.0% lines 118
tests/core/mempool/test_mempool.py 0.0% lines 2507, 2524, 2560, 2580, 2599
tests/core/test_cost_calculation.py 0.0% lines 210, 306
tests/wallet/test_offer_parsing_performance.py 0.0% lines 31
Total Missing Coverage
9 lines 9 lines 0%

@cmmarslender cmmarslender merged commit ca59c50 into main Oct 24, 2023
245 of 246 checks passed
@cmmarslender cmmarslender deleted the fc.bench branch October 24, 2023 21:07
This was referenced Oct 28, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn left review comments

@emlowe emlowe emlowe approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
coverage-diff Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fchirica @arvidn @altendky @emlowe @cmmarslender