add time out assert data collection and presentation #16831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Changed
altendky
changed the title
Pull Request Test Coverage Report for Build 7483078014
💛 - Coveralls |
github-actions
bot
added
coverage-diff
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
1 similar comment
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
emlowe
previously approved these changes
Feb 2, 2024
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
merge_conflict
emlowe
approved these changes
Feb 2, 2024
|
cmmarslender
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Adds time out assertion data collection and presentation similar to what was added for benchmarks.
https://github.com/Chia-Network/chia-blockchain/actions/runs/6884258354?pr=16831
I am personally comfortable leaving the remaining
TODO:s in place for later improvements.Current Behavior:
New Behavior:
Testing Notes:
Top 50 Time Out Asserts: https://github.com/Chia-Network/chia-blockchain/actions/runs/6898367177?pr=16831#summary-18769328079
Benchmarks: https://github.com/Chia-Network/chia-blockchain/actions/runs/6898367139?pr=16831#summary-18768254817
Draft For:
time_out_assert()family back to tests #16846