Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_status accidental arg #16860

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix set_status accidental arg #16860

merged 1 commit into from
Nov 20, 2023

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Nov 17, 2023 •
edited
Loading

A new kwarg got added and this broke

#16817

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Nov 17, 2023
@Quexington Quexington marked this pull request as ready for review November 17, 2023 21:07
@Quexington Quexington requested a review from a team as a code owner November 17, 2023 21:07
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 6907418971

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 112 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.268%
Files with Coverage Reduction New Missed Lines %
chia/data_layer/data_layer.py 1 82.1%
chia/server/node_discovery.py 1 79.73%
chia/timelord/timelord_launcher.py 1 69.77%
chia/wallet/wallet_node.py 1 88.16%
tests/simulation/test_simulation.py 1 96.52%
chia/data_layer/data_layer_wallet.py 2 91.09%
chia/full_node/weight_proof.py 2 90.89%
chia/timelord/timelord_api.py 2 87.85%
chia/full_node/full_node.py 5 85.19%
chia/full_node/full_node_api.py 7 77.24%
Totals Coverage Status
Change from base Build 6898618925: -0.07%
Covered Lines: 93667
Relevant Lines: 103709
💛 - Coveralls

wjblanke
wjblanke approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok!

@cmmarslender cmmarslender merged commit d09b3a8 into main Nov 20, 2023
249 checks passed
@cmmarslender cmmarslender deleted the quex.fix_set_status branch November 20, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quexington @wjblanke @cmmarslender