switch transaction queue completion to a new ValuedEvent
#17305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
#17171 was the introducing pr.
it seems this error would have been triggered when the api handler timed out waiting for the transaction to be processed and the transaction processing later completed. i didn't feel great about using the future there and ended up getting bit by it. when awaiting a future gets cancelled it marks the future itself as cancelled. when something later attempts to set a result on it the invalid state error is raised. in this case, i believe the only effect of this bug is the logging of the error.
Current Behavior:
New Behavior:
Testing Notes: