Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch transaction queue completion to a new ValuedEvent #17305

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 12, 2024

Purpose:

#17171 was the introducing pr.
it seems this error would have been triggered when the api handler timed out waiting for the transaction to be processed and the transaction processing later completed. i didn't feel great about using the future there and ended up getting bit by it. when awaiting a future gets cancelled it marks the future itself as cancelled. when something later attempts to set a result on it the invalid state error is raised. in this case, i believe the only effect of this bug is the logging of the error.

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jan 12, 2024
@altendky altendky marked this pull request as ready for review January 12, 2024 15:20
@altendky altendky requested a review from a team as a code owner January 12, 2024 15:20
@altendky altendky requested a review from arvidn January 12, 2024 15:20
Copy link

Pull Request Test Coverage Report for Build 7503678079

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 90.484%

Totals Coverage Status
Change from base Build 7497287764: -0.05%
Covered Lines: 94583
Relevant Lines: 104480

💛 - Coveralls

@cmmarslender cmmarslender merged commit 78b7904 into main Jan 16, 2024
264 checks passed
@cmmarslender cmmarslender deleted the fixup_unexpected_future_cancellation branch January 16, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants