Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaner cli output for rpc client fetch errors #17460

Merged
merged 17 commits into from
Feb 23, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Feb 1, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Feb 1, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed merge_conflict Branch has conflicts that prevent merge to main labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

coveralls-official bot commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7834819534

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 61 (100.0%) changed or added relevant lines in 4 files are covered.
  • 286 unchanged lines in 33 files lost coverage.
  • Overall coverage decreased (-0.07%) to 90.799%

Files with Coverage Reduction New Missed Lines %
chia/daemon/client.py 1 84.38%
chia/daemon/keychain_proxy.py 1 64.98%
chia/data_layer/download_data.py 1 71.04%
chia/farmer/farmer.py 1 72.67%
chia/introducer/introducer.py 1 78.26%
chia/plotters/plotters.py 1 90.94%
chia/server/server.py 1 80.0%
chia/timelord/timelord_launcher.py 1 70.54%
chia/wallet/wallet_state_manager.py 1 96.32%
tests/core/util/test_file_keyring_synchronization.py 1 97.1%
Totals Coverage Status
Change from base Build 7830053184: -0.07%
Covered Lines: 96773
Relevant Lines: 106532

💛 - Coveralls

@altendky altendky changed the title cleaner rpc client fetch errors cleaner cli output for rpc client fetch errors Feb 9, 2024
@altendky altendky requested review from fchirica and emlowe February 9, 2024 14:17
@altendky altendky marked this pull request as ready for review February 9, 2024 14:17
@altendky altendky requested a review from a team as a code owner February 9, 2024 14:17
@Starttoaster Starttoaster merged commit 1855f99 into main Feb 23, 2024
268 checks passed
@Starttoaster Starttoaster deleted the cleaner_rpc_client_fetch_errors branch February 23, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants